Project

General

Profile

Actions

Bug #25298

closed

No "=" sign is allowed in value part of flashvars of MEDIA element

Added by Kai Vogel almost 14 years ago. Updated about 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2011-03-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.2
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Problem:
-------------------------
In File "class.tslib_content_media.php" in line 158 the flashvars will be exploded at the "=" sign into key and value. But all "=" signs in the value part are exploded too. Such a value is possible for e.g. an URL to get a dynamic XML for the flash application: index.php?id=2&type=96

Solution:
-------------------------
The trimExplode must be called with an fourth parameter to limit the parts to two.

Change:
$valueParts = t3lib_div::trimExplode('=', $parts1, TRUE);

To:
$valueParts = t3lib_div::trimExplode('=', $parts1, TRUE, 2);

(issue imported from #M17913)

Actions #1

Updated by Mathias Schreiber almost 10 years ago

  • Description updated (diff)
  • Category deleted (Communication)
  • Target version changed from 0 to 7.2 (Frontend)
  • Is Regression set to No
Actions #2

Updated by Benni Mack over 9 years ago

  • Target version changed from 7.2 (Frontend) to 7.4 (Backend)
Actions #3

Updated by Gerrit Code Review over 9 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41699

Actions #4

Updated by Susanne Moog over 9 years ago

  • Target version changed from 7.4 (Backend) to 7.5
Actions #5

Updated by Gerrit Code Review over 9 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41699

Actions #6

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/41699

Actions #7

Updated by Georg Ringer over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Riccardo De Contardi about 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF