TYPO3 Core

What's going on with this issue?

what can I do to push this? In the core, bug 18520 has all patches for 4.3,4.4 and 4.5

I saw that in the new master branch someone (I'm new to git - could not see details..) worked on this file but instead of adding the open_basedir check (s)he kicked out the safemode check:

4.5 branch:

switch($extension) {
case 'pdf':
// PDF
if ($indexerConfig['pdftools']) {
$pdfPath = rtrim($indexerConfig['pdftools'], '/').'/';
if ($safeModeEnabled || (@is_file($pdfPath . 'pdftotext' . $exe) && @is_file($pdfPath . 'pdfinfo' . $exe))) {
$this->app['pdfinfo'] = $pdfPath.'pdfinfo'.$exe;
$this->app['pdftotext'] = $pdfPath.'pdftotext'.$exe;
// PDF mode:
$this->pdf_mode = t3lib_div::intInRange($indexerConfig['pdf_mode'],-100,100);
$extOK = TRUE;
} else $this->pObj->log_setTSlogMessage(sprintf($this->sL('LLL:EXT:indexed_search/locallang.xml:pdfToolsNotFound'), $pdfPath), 3);
} else $this->pObj->log_setTSlogMessage($this->sL('LLL:EXT:indexed_search/locallang.xml:pdfToolsDisabled'), 1);
break;


new master branch:

switch($extension) {
case 'pdf':
// PDF
if ($indexerConfig['pdftools']) {
$pdfPath = rtrim($indexerConfig['pdftools'], '/').'/';
if (@is_file($pdfPath . 'pdftotext' . $exe) && @is_file($pdfPath . 'pdfinfo' . $exe)) {
$this->app['pdfinfo'] = $pdfPath.'pdfinfo'.$exe;
$this->app['pdftotext'] = $pdfPath.'pdftotext'.$exe;
// PDF mode:
$this->pdf_mode = t3lib_div::intInRange($indexerConfig['pdf_mode'],-100,100);
$extOK = TRUE;
} else $this->pObj->log_setTSlogMessage(sprintf($this->sL('LLL:EXT:indexed_search/locallang.xml:pdfToolsNotFound'), $pdfPath), 3);
} else $this->pObj->log_setTSlogMessage($this->sL('LLL:EXT:indexed_search/locallang.xml:pdfToolsDisabled'), 1);
break;


I'll do some tests but I think is_file won't return true if either safemode is enabled (ok this will be no more a problem with PHP6...) or open_basedir is set (and does not include the path to the file...)

is_file needs php access to the file (open_basedir) - exec does not....

/Ch

Yes - it does.

in Classes/FileContentParser.php we have this, as an example:

 if (@is_file(($pdfPath . 'pdftotext' . $exe)) && @is_file(($pdfPath . 'pdfinfo' . $exe))) {

this won't pass when open_basedir ist activated - with this one it works:

 if (ini_get('open_basedir') || (@is_file(($pdfPath . 'pdftotext' . $exe)) && @is_file(($pdfPath . 'pdfinfo' . $exe)))) {

php.ini:
open_basedir = "/var/www/virtual/<domain>:/usr/share/php:/var/www/webapps/:/usr/bin/"

I don't get an error (is_file... is not in allowed directory) but it's always false... even if file is there...)

btw: 6.2.9 :-)

Sorry guys
I was wrong.
is_file works with open_basedir

It works with 6.2.9 out of the box.
My fault...

So this issue and #18520 can be closed?