Project

General

Profile

Actions
Copy link

Bug #25834

closed

sql_fetch_assoc can return an empty array

Added by Gabe Blair over 13 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Xavier Perseguers
Category:
Database API (Doctrine DBAL)
Target version:
-
Start date:
2011-04-07
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

It is possible for ux_t3lib_DB::sql_fetch_assoc() to return an empty array in DBAL. This is a problem, for example, in t3lib_pageSelect::getWorkspaceVersionOfRecord(), because is_array() alone is checked on a result row (returning false positives in the case that the row is an empty array) to see if a record has an offline version.

I'll submit a patch to Gerrit for this one - it's my first attempt at contributing here, so please go easy on me!

Thanks

Actions
Copy link
 #1

Updated by Gabe Blair over 13 years ago

Added a patch to Gerrit for review: http://review.typo3.org/1504

Thanks.

Actions
Copy link
 #2

Updated by Xavier Perseguers over 13 years ago

  • Project changed from TYPO3 Core to 329
  • Category deleted (999)
Actions
Copy link
 #3

Updated by Xavier Perseguers over 13 years ago

  • Subject changed from DBAL: sql_fetch_assoc can return an empty array to sql_fetch_assoc can return an empty array
Actions
Copy link
 #4

Updated by Xavier Perseguers over 13 years ago

Hi Gabe,

Thanks for your first contribution. You did not notice but DBAL has its own repository which gets merged in Core before releases.

May I kindly ask you to abandon your Gerrit review (there's a button for that purpose) and recreate your patch for this repository? Thanks.

Actions
Copy link
 #5

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change I4c7df9bdc52a440de28d96e01ca3682db389df05 has been pushed to the review server.
It is available at http://review.typo3.org/1509

Actions
Copy link
 #6

Updated by Gabe Blair over 13 years ago

Thanks Xavier - I've pushed the patch to the DBAL repository for review, this time tagging it with the "Review: #..." line.

Actions
Copy link
 #7

Updated by Mr. Hudson over 13 years ago

Patch set 2 of change I4c7df9bdc52a440de28d96e01ca3682db389df05 has been pushed to the review server.
It is available at http://review.typo3.org/1509

Actions
Copy link
 #8

Updated by Mr. Hudson over 13 years ago

Patch set 3 of change I4c7df9bdc52a440de28d96e01ca3682db389df05 has been pushed to the review server.
It is available at http://review.typo3.org/1509

Actions
Copy link
 #9

Updated by Mr. Hudson over 13 years ago

Patch set 1 of change If5d104f1cea6d79133d4c710fef87c64476147be has been pushed to the review server.
It is available at http://review.typo3.org/1549

Actions
Copy link
 #10

Updated by Xavier Perseguers over 13 years ago

  • Status changed from New to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #11

Updated by Xavier Perseguers over 13 years ago

  • Assignee set to Xavier Perseguers
Actions
Copy link
 #12

Updated by Michael Stucki almost 11 years ago

  • Project changed from 329 to TYPO3 Core
Actions
Copy link
 #13

Updated by Michael Stucki almost 11 years ago

  • Category set to 999
Actions
Copy link
 #14

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF