Bug #26133

Fix broken string replacement for media/ folder

Added by Patrick Rodacker almost 9 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2011-04-19
Due date:
% Done:

0%

TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The function setAbsRefPrefix() of the class tslib_fe includes the following string replacement, which is obsolete and should be removed.

$this->content = str_replace('"media/', '"'.t3lib_extMgm::siteRelPath('cms').'tslib/media/', $this->content);

Related issues

Related to TYPO3 Core - Bug #25028: Remove cms/tslib/media folder to TER extension Closed 2011-02-14
Related to TYPO3 Core - Bug #25985: remove obsolete check for dir media/scripts/ in Function tslib_fe::checkFileInclude Closed 2011-04-15
Related to TYPO3 Core - Task #28024: Remove tslib/media, cglify statictemplates/media Closed 2011-07-09

History

#1 Updated by Mr. Hudson almost 9 years ago

Patch set 1 of change Ie9736d815308c20f609f58da2cda735dcdc0a037 has been pushed to the review server.
It is available at http://review.typo3.org/2363

#2 Updated by Susanne Moog almost 9 years ago

  • Status changed from New to Under Review

#3 Updated by Patrick Rodacker almost 9 years ago

From Gerrit:

Susanne Moog        May 24
Patch Set 1: I would prefer that you didn't submit this
As far as I can see we should not remove the replacement as TYPO3 core still 
allows the media/ folder as valid place for storing scripts and media files 
(see t3lib_tstemplate for example) - if someone is still using that directory 
for file inclusion this patch will break paths if absRefPrefix is used.
We should deprecate the inclusion of files in the media folder first.

How do we deprecate the inclusion from the media/ folder first?

I read in another post, that a htaccess file with an AJAX call to write the log could be used.

#4 Updated by Steffen Gebert about 8 years ago

  • Status changed from Under Review to Rejected

#5 Updated by Steffen Gebert about 8 years ago

  • Status changed from Rejected to Under Review

#6 Updated by Chris topher almost 8 years ago

Now this folder has been removed from the TYPO3 Core. The replacement, which you quoted above, is still there and will not work anymore. Instead the files from statictemplates/media should be used.

#7 Updated by Chris topher almost 8 years ago

  • Subject changed from remove obsolete string replacement for media/ folder in tslib_fe::setAbsRefPrefix to Fix broken string replacement for media/ folder
  • Target version set to 6.0.0-pre-beta1

#8 Updated by Alexander Opitz almost 7 years ago

  • Status changed from Under Review to New
  • Target version deleted (6.0.0-pre-beta1)

Patch was abandoned

#9 Updated by Riccardo De Contardi over 5 years ago

the line reported is still present in 4.5.39, but does not exists in 6.2.9

#10 Updated by Wouter Wolters over 5 years ago

  • Status changed from New to Closed
  • Is Regression set to No

Hi, as we removed the complete media stuff I'll close this ticket.

Also available in: Atom PDF