Bug #26660: imagecopyresized has invalid function parameter - TYPO3 Core - TYPO3 Forge

Custom queries

12 LTS
Accessibility
Dashboard issues
Easy tasks
Extbase Issues
FAL Issues
FAL Sprint 2023
Hierarchical Issues
Issues reported for v11
JavaScript issues
JavaScript Issues (w/o Epics/Stories)
Most wanted Bugfixes
Most wanted Features
My open issues
New & Unassigned
No feedback within 90 days
Open Bugs
Open issues of 10
Page Tree Regressions after 2020-07-28
Recently modified
Regressions
Stabilization Issues
Usability or UX

Actions

Copy link

Bug #26660

closed

imagecopyresized has invalid function parameter

Added by Benjamin Schulte almost 13 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Benjamin Schulte

Category:

Target version:

Start date:

2011-05-06

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.5

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

The class t3lib_stdgraphic provides the method imagecopyresized with a parameter list which defines the parameters $w and $h twice.

Due to this, it is impossible to create a mock of the stdGraphic class using PHPUnit.

In any way, I don't know how the method should work correctly.

function imagecopyresized(&$im, $cpImg, $Xstart, $Ystart, $cpImgCutX, $cpImgCutY, $w, $h, $w, $h)

Related issues 2 (0 open — 2 closed)

Related to TYPO3 Core - Bug #36947: GIFBUILDER render twice

Closed

TYPO3 Release Team

2012-05-08

Actions

Related to TYPO3 Core - Bug #39563: Regression in t3lib_iconWorks::imagecopyresized

Closed

2012-08-06

Actions

Issue # Delay: days Cancel

History
Notes
Property changes
Associated revisions

Actions

Copy link

Updated by Mr. Hudson almost 13 years ago

Patch set 1 of change Id43229caa3694e8859f9912946c963f907f92951 has been pushed to the review server.
It is available at http://review.typo3.org/2564

Actions

Copy link

Updated by Stefan Neufeind almost 13 years ago

Quickly hacked together script to check for duplicate params. Detected two occurences of this here and didn't find something else on Core, extbase, fluid or FLOW3.

search, leave out some comment-lines
$ grep "function " -R * | grep -v \* >found

find-script:
$fp = fopen("found", "r");
while($s = fgets($fp)) {
$params = $s;
$pos = strpos($params, '(');
if($pos <= 0) continue;
$params = substr($params, $pos+1);

$pos = strpos($params, ')');
                if($pos <= 0) continue;
                $params = substr($params, 0, $pos);

$aParams = explode(',', $params);
                $aParams = array_map('trim', $aParams);

if(count($aParams) != count(array_unique($aParams))) {
                        var_dump($s);
                }
          }

Actions

Copy link

Updated by Mr. Hudson over 12 years ago

Patch set 2 of change Id43229caa3694e8859f9912946c963f907f92951 has been pushed to the review server.
It is available at http://review.typo3.org/2564

Actions

Copy link

Updated by Thorsten Kahler over 12 years ago

Status changed from New to Needs Feedback
Assignee set to Benjamin Schulte

Does this grievance really produce any errors? From what I read from PHPDoc this is just a wrapper method for internal use and the duplicated variable names always should be assigned the same values.

Actions

Copy link