Bug #26784: Get page changes by complex TemplaVoila DS - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #26784

closed

Get page changes by complex TemplaVoila DS

Added by Lyuben Vassilev almost 13 years ago. Updated over 9 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Workspaces

Target version:

Start date:

2011-05-12

Due date:

% Done:

Estimated time:

TYPO3 Version:

4.6

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

I have a page that contain a TemplaViola content element. When I want to see the changes for some workspace for this page the request

/typo3/ajax.php?ajaxID=ExtDirect::route&namespace=TYPO3.Workspaces

takes so long so it get aborted from the browser. In the backend there is a message(shown 4 times):

"Connection Problem Sorry, but an error occurred while connecting to the server. Please check your network connection."

I started to search where the problem comes from and it was from

typo3/sysext/workspaces/Classes/Service/GridData.php

There is a function "calculateChangePercentage" that do not works with a little bit more complex DS.

I think there must be a way not to calculate this value if it provide a crash as by me.

Files

Download all files

ds.xml (15.3 KB) ds.xml		Lyuben Vassilev, 2011-05-12 15:53
tt_content.tx_templavoila_flex.xml (53.2 KB) tt_content.tx_templavoila_flex.xml	data of the field tx_templavoila_flex	Lyuben Vassilev, 2011-05-13 11:41

Actions

Copy link

Updated by Oliver Hader almost 13 years ago

Status changed from New to Needs Feedback

Thanks for your report. Since you were able to track down this issue to the calculateChangePercentage() method, can you please do additional debugging on whether the call to t3lib_BEfunc::getProcessedValue() (maybe a hook there?) or similar_text() is taking that much time - you could do this e.g. by just uncommenting the accordant lines.

How big is the data stored in the flexform field - I guess the problem is the similar_text() function. Thanks in advance!

Actions

Copy link

Updated by Lyuben Vassilev almost 13 years ago

File tt_content.tx_templavoila_flex.xml tt_content.tx_templavoila_flex.xml added

Hi,

I attached the data of the field tx_templavoila_flex. It is about 54 KB. All other filed of this entry seams normal. Only l18n_diffsource = [BLOB - 445B], but I think this is normal too.

I will check where the problem comes from in the next days.

Actions

Copy link

Updated by Lyuben Vassilev almost 13 years ago

Hi again! I tested and the problem comes really from

similar_text($val1, $val2, $similarityPercentage);

I have made var_dump() of $val1 and $val2 just for your info. $val1 is string(56412), $val2 is string(83748);
By such a volume of data the similar_text seems not to work properly any more.

You can read this too: http://www.php.net/manual/en/function.similar-text.php#72448

Actions

Copy link

Updated by Oliver Hader almost 13 years ago

Target version deleted (~~4.5.3~~)

Actions

Copy link

Updated by Tolleiv Nietsch over 12 years ago

Status changed from Needs Feedback to Accepted
TYPO3 Version set to 4.6

So the TODO here is to work around the know issues within PHP-functions e.g. by processing of 10KB chunks.

Actions

Copy link

Updated by Michael Voehringer about 12 years ago

I ran into the same problem as Lyuben but my solution was to remove the call of calculateChangePercentage, because i did not found the usage of the calulated value. Aslong as you do not display the value there is no need to calculate it ;)

Actions

Copy link

Updated by Tobias Frasch over 11 years ago

Same problem exists for me. All of a sudden viewing workspace changes stopped working. After removing the call of calculateChangePercentage it worked again.

Actions

Copy link

Updated by Michael Voehringer about 11 years ago

I think you can close this ticket, in the meantime someone removed the calculateChangePercentage function and i can not reporduce this issue any more.

Actions

Copy link