Bug #27287

Bug #46389: Faulty Workspace Placeholders

Wrong languages in page module & Fatal error

Added by Georg Ringer over 9 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2011-06-08
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
Tags:
Complexity:
hard
Is Regression:
No
Sprint Focus:

Description

The function exec_languageQuery in cms/layout/db_layout doesn't care about workspaces which brings a lot of troubles including a fatal error

How to reproduce:
  1. You need to have at least 2 sys_language
  2. Create a page in live WS & create a tanslation in language 1
  3. Switch to a workspace and create a translation in language 2
  4. Switch back to live and go to the page
  5. => Boooom

It wouuld be easy to use a typecast in class.tx_cms_layout.php, line 685 below the "list($lpRecord);

$lpRecord = (array)$lpRecord;

please proceed with that patch to see further problem: When you switch back to live workspaces, you will now see both languages on that page but the language #2 has been created in a workspace, so it shouldn't be visible, right? You will also see the 2nd language in the select box at the top left corner of the module.

Hiding the language would be very easy:
cms/layout/db_layout.php in function exec_languageQuery below the $exQ = t3lib_BEfunc:::deleteClause add this line

t3lib_BEfunc::versioningPlaceholderClause('pages_language_overlay');

Now everything looks fine as you only see the language #1 which has been created in live workspace and you can also remove the typecast and it still works but there is now another issue:
if you want to create the 2nd language in live WS, you will have this language twice (easly to spot in the list module).

So I really don't know how to proceed and what the best way is.

thanks for feedback, also for retesting everything!

#1

Updated by Andreas Wolf about 9 years ago

  • Complexity set to hard

I guess we will need to have some kind of placeholders for language overlays that were created in a draft workspace - like with movement placeholders. Or do you see another possibility, Georg?

#2

Updated by Oliver Hader over 7 years ago

  • Parent task set to #46389
#3

Updated by Philipp Gampe over 7 years ago

  • Category changed from Backend User Interface to Backend API
  • Status changed from New to Needs Feedback

Still valid?

#4

Updated by Alexander Opitz almost 7 years ago

  • Status changed from Needs Feedback to Closed
  • Is Regression set to No

No feedback within the last 90 days => closing this ticket.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

Also available in: Atom PDF