Bug #28536
closed
JSwindow-typolink URLs are encoded twice with htmlspecialchars()
Added by Torben Hansen about 13 years ago.
Updated almost 7 years ago.
Category:
Content Rendering
Description
#28189 introduces a bug in JSwindow-typolink URLs, which are being encoded twice with htmlspecialchars().
In "class.tslib_content.php" line 5905 t3lib_div::quoteJSvalue is called, which does htmlspecialchars() on the final URL. Then, in line 5908 again htmlspecialchars() is called for the same URLs, which already has been encoded in line 5905.
This results in non working URLs with double ampersands like this:
www.domain.tld/index.php?id=1&parameter1&parameter2
Removing the htmlspecialchars() in line 5905 resolves the problem.
Files
- Status changed from New to Accepted
- Assignee set to Helmut Hummel
attached patch fixes that
Thanks! Patch is working.
Patch set 1 of change If6bcad4d2bf1e0a4b3f5a6f04e4718df8e4e7150 has been pushed to the review server.
It is available at http://review.typo3.org/3901
Steps to reproduce:
1. Use the following Typoscript:
lib.printLink = TEXT
lib.printLink {
value = Print Page
htmlSpecialChars = 1
typolink.parameter = # 800x600:scrollbars=yes
typolink.additionalParams = &print=1
typolink.addQueryString = 1
}
page.1 < lib.printLink
2. Click on the link
- Status changed from Accepted to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to Under Review
Patch set 1 of change If6bcad4d2bf1e0a4b3f5a6f04e4718df8e4e7150 has been pushed to the review server.
It is available at http://review.typo3.org/3913
Patch set 1 of change If6bcad4d2bf1e0a4b3f5a6f04e4718df8e4e7150 has been pushed to the review server.
It is available at http://review.typo3.org/3914
Patch set 1 of change If6bcad4d2bf1e0a4b3f5a6f04e4718df8e4e7150 has been pushed to the review server.
It is available at http://review.typo3.org/3915
- Status changed from Under Review to Resolved
- Status changed from Resolved to Closed
Also available in: Atom
PDF