Project

General

Profile

Actions

Bug #28951

closed

modulemenu.js: Showmodule can be called before Store is loaded

Added by Thomas Pilgaard Carlsen over 12 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
-
Target version:
Start date:
2011-08-12
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
5.2
Tags:
Complexity:
medium
Is Regression:
Sprint Focus:

Description

Example: Using the direct page edit feature (backend.php?edit=xxx) the BE responds with "Module loader
No module found. If this is a temporary error, please reload the Backend!" error. I found that the ajax loading of modules in modulemenu.js took almost 1 second on this particular installation and therefore showModule was called before the modules had finished loading.

I introduced the following hack in showModule after which the BE successfully could load the page edit module:

showModule: function(mod, params) {
        if(TYPO3.ModuleMenu.Store.getCount() == 0){
            setTimeout("top.TYPO3.ModuleMenu.App.showModule('"+mod+"', '"+params+"')", 1000);
            return;
        }

A better approach would probably be to make the modulemenu block until it had completed it's initialization.


Related issues 1 (0 open1 closed)

Precedes TYPO3 Core - Bug #30771: Fix not working backend.php?edit=pidClosedKay Strobach2011-10-11

Actions
Actions #1

Updated by Susanne Moog over 12 years ago

  • Status changed from New to Accepted
  • Target version set to 4.6.0-beta2
  • Complexity set to medium
Actions #2

Updated by Xavier Perseguers over 12 years ago

  • Target version changed from 4.6.0-beta2 to 4.6.0-beta3
Actions #3

Updated by Oliver Hader over 12 years ago

  • Target version changed from 4.6.0-beta3 to 4.6.0-RC1
Actions #4

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change Ia7c39fc94e75ef003a7a839856ea78cbd0854a66 has been pushed to the review server.
It is available at http://review.typo3.org/5681

Actions #5

Updated by Xavier Perseguers over 12 years ago

  • Status changed from Accepted to Under Review
Actions #6

Updated by Mr. Hudson over 12 years ago

Patch set 2 of change Ia7c39fc94e75ef003a7a839856ea78cbd0854a66 has been pushed to the review server.
It is available at http://review.typo3.org/5681

Actions #7

Updated by Mr. Hudson over 12 years ago

Patch set 3 of change Ia7c39fc94e75ef003a7a839856ea78cbd0854a66 has been pushed to the review server.
It is available at http://review.typo3.org/5681

Actions #8

Updated by Mr. Hudson over 12 years ago

Patch set 4 of change Ia7c39fc94e75ef003a7a839856ea78cbd0854a66 has been pushed to the review server.
It is available at http://review.typo3.org/5681

Actions #9

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change I555427d61845678c1f90e2039c41cdd2055e5b6a has been pushed to the review server.
It is available at http://review.typo3.org/5712

Actions #10

Updated by Xavier Perseguers over 12 years ago

  • Status changed from Under Review to Resolved
  • Assignee set to Oliver Hader
  • % Done changed from 0 to 100
Actions #11

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF