Bug #29366: Disabling the cache does not work on invalid cHash value - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #29366

closed

Disabling the cache does not work on invalid cHash value

Added by Daniel Poetzinger over 12 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Caching

Target version:

4.3.14

Start date:

2011-08-30

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.3

PHP Version:

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

The conditions:

$TYPO3_CONF_VARS['FE']['pageNotFoundOnCHashError'] = 0;
$TYPO3_CONF_VARS['FE']['disableNoCacheParameter'] = 1;

URL with wrong cHash like
http://domain.com?id=1&someArgument=10000&cHash=ABCDEF

tslib_fe:makeCacheHash() will call tslib_fe::set_no_cache() and that
method will do nothing since 'disableNoCacheParameter' is enabled. So
the cache is not disabled to that request. If not there is no cache it
in the database, the contents will be created and cached.

So it should be possible to create a script that loops over the cHash
and iterates it.

Actions

Copy link

Updated by Mr. Hudson over 12 years ago

Patch set 1 of change I9df3d7b4bf1d565fc5a429bad6ee2d3d186f6044 has been pushed to the review server.
It is available at http://review.typo3.org/4705

Actions

Copy link

Updated by Daniel Poetzinger over 12 years ago

% Done changed from 0 to 100

http://review.typo3.org/4705

Actions

Copy link

Updated by Mr. Hudson over 12 years ago

Patch set 2 of change I9df3d7b4bf1d565fc5a429bad6ee2d3d186f6044 has been pushed to the review server.
It is available at http://review.typo3.org/4705

Actions

Copy link

Updated by Steffen Gebert over 12 years ago

Thanks for the patch, Daniel.

What do you mean with that?

So it should be possible to create a script that loops over the cHash and iterates it.

I have updated your commit to contain your bug description in the commit message. Could you please check, whether it still makes sense?

Thanks
Steffen

Actions

Copy link

Updated by Daniel Poetzinger over 12 years ago

Sure - still makes sense - thanks!

The sentence is a bit confusing - what it means is, that a call like ?someparameter=1&cHash=someWrongChash will result in new cache entry if the TYPO3 settings are like described.

Actions

Copy link

Updated by Andreas Wolf over 12 years ago

Category set to Caching
Target version set to 4.6.0-beta3
Complexity changed from no-brainer to easy

Would it make sense to also include that into 4.5?

Actions

Copy link

Updated by Ernesto Baschny over 12 years ago

Target version changed from 4.6.0-beta3 to 4.5.6

@Andreas Otto †, definitively!

Actions

Copy link

Updated by Mr. Hudson over 12 years ago

Patch set 3 of change I9df3d7b4bf1d565fc5a429bad6ee2d3d186f6044 has been pushed to the review server.
It is available at http://review.typo3.org/4705

Actions

Copy link

Updated by Mr. Hudson over 12 years ago

Patch set 4 of change I9df3d7b4bf1d565fc5a429bad6ee2d3d186f6044 has been pushed to the review server.
It is available at http://review.typo3.org/4705

Actions

Copy link

#10

Updated by Oliver Hader over 12 years ago

Subject changed from Flooding of TYPO3 Cache to Disabling the cache does not work on invalid cHash value
Status changed from New to Accepted
Target version changed from 4.5.6 to 4.3.14
TYPO3 Version changed from 4.6 to 4.3