Project

General

Profile

Actions

Bug #30212

closed

Wrong marker in notification mail message: USER_FULLNAME vs. USER_REALNAME

Added by Andreas Kießling about 13 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Workspaces
Target version:
-
Start date:
2011-09-22
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The language file from versions has this line as default message that is sent as the notification mail:

State was changed by ###USER_FULLNAME### (username: ###USER_USERNAME###)

but the marker that is replaced in the class.tx_version_tcemain.php is ###USER_REALNAME###

###USER_REALNAME### probably makes more sense, since that is the field from be_users table

Actions #1

Updated by Jigal van Hemert about 13 years ago

It seems more practical to me to change the marker in tx_version_tcemain::notifyStageChange() simply because the template is in the translation server. 'Labels' should not be changed once they are used because this would require changes in all translations too.

Actions #2

Updated by Andreas Kießling about 13 years ago

Ok, good point. I don't think that too many workspace users have customized the message anyway.

Actions #3

Updated by Mr. Hudson about 13 years ago

Patch set 1 of change Ibc50e4ab881ab21b590d394ebf7dc59a0b000e6e has been pushed to the review server.
It is available at http://review.typo3.org/5613

Actions #4

Updated by Tolleiv Nietsch about 13 years ago

  • Status changed from New to Under Review
Actions #5

Updated by Tolleiv Nietsch about 13 years ago

Please test the patch - I'd suggest to keep both markers for some time.

Actions #6

Updated by Mr. Hudson about 13 years ago

Patch set 2 of change Ibc50e4ab881ab21b590d394ebf7dc59a0b000e6e has been pushed to the review server.
It is available at http://review.typo3.org/5613

Actions #7

Updated by Tolleiv Nietsch about 13 years ago

  • Status changed from Under Review to Resolved
Actions #8

Updated by Michael Stucki almost 11 years ago

  • Category changed from Bugs to Workspaces
Actions #9

Updated by Michael Stucki almost 11 years ago

  • Project changed from 624 to TYPO3 Core
  • Category changed from Workspaces to Workspaces
Actions #10

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF