Bug #31460

flock() in class.t3lib_div.php

Added by Timm almost 11 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Should have
Category:
-
Target version:
-
Start date:
2011-10-31
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hi,

we're serving T3 v4.6.0 from NFS. First thanks for the last release with some alternative locking methods.

At line 5499 and 5584 in file ./typo3_src-4.6.0/t3lib/class.t3lib_div.php we found some flock()-calls wich breaks down php.

Our workaround is to comment out the flock()s.

Support for new locking methods in class.t3lib_div.php would be great.

There are also some other files with flock():

./typo3_src-4.6.0/typo3/sysext/adodb/adodb/adodb-active-record.inc.php:361: @flock($fp, LOCK_SH);
./typo3_src-4.6.0/typo3/sysext/adodb/adodb/adodb-active-recordx.inc.php:420: @flock($fp, LOCK_SH);
./typo3_src-4.6.0/typo3/sysext/adodb/adodb/adodb-csvlib.inc.php:103: @flock($fp, LOCK_SH);
./typo3_src-4.6.0/typo3/sysext/adodb/adodb/adodb-csvlib.inc.php:305: if (flock($fd, LOCK_EX) && ftruncate($fd, 0)) {
./typo3_src-4.6.0/t3lib/mail/class.t3lib_mail_mboxtransport.php:101: flock($file, LOCK_EX);
./typo3_src-4.6.0/t3lib/mail/class.t3lib_mail_mboxtransport.php:103: flock($file, LOCK_UN);

Regards,

timm


Related issues

Related to TYPO3 Core - Bug #34662: Fatal error 't3lib_lock' does not exist if deprecationLog = 'file'Closed2012-03-08

Actions
Related to TYPO3 Core - Bug #18716: Acquired lock/Released lock entries in system logClosedMichael Stucki2008-04-28

Actions
#1

Updated by Francois Suter almost 11 years ago

Hi Timm, thanks for reporting. I must admit that I'm not at all into the locking mechanism, I hope someone else can help you.

Would you be able to provide a patch yourself? It would greatly enhance the chances of seeing those changes made to the TYPO3 Core.

BTW I don't think the flock's inside adodb will be changed, as this is just included as a contribution.

#2

Updated by Dmitry Dulepov over 10 years ago

  • Status changed from New to Under Review
  • Assignee set to Dmitry Dulepov
#3

Updated by Gerrit Code Review over 10 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/6778

#4

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/7504

#5

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/7506

#6

Updated by Dmitry Dulepov over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#7

Updated by Gerrit Code Review over 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9360

#8

Updated by Dmitry Dulepov over 10 years ago

  • Status changed from Under Review to Resolved
#9

Updated by Benni Mack almost 4 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF