Bug #31978

tcaTree: PHP Warning: Missing argument 2 for extDirect_DataProvider_BackendUserSettings::addToList()

Added by Georg Ringer over 9 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
Start date:
2011-11-22
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
5.3
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

the tcatree throws an error every time it is called. I am not into ExtJS and neither into the tcaTree itself but IMO those information should be enough to fix it.

How to test
-------------
Install EXT:news, create at least one category and call either the category record or the plugin - both got a tca tree implemented

Information from debugging
---------------------------
The error comes from class t3lib_TCEforms_Tree which got an inline JS

expandnode: function(node) {
        top.TYPO3.BackendUserSettings.ExtDirect.addToList("tcaTrees." + this.ucId, node.attributes.uid);
}

Problem is that node.attributes.uid is undefined. This happens with the root node

Using this code to debug

if (node.attributes.uid) {
    top.TYPO3.BackendUserSettings.ExtDirect.addToList("tcaTrees." + this.ucId, node.attributes.uid);
} else {
    alert(node);
}

shows 2 alert boxes with:
[Node xnode-27]
[Node root]

Possible solutions ======================
As already stated, I no nothing about ExtJS but there are IMO 2 possible solutions:
1) Use an if clause "if (node.attributes.uid) {"

2) Maybe it is even more simple as IMO it should be node.attributes.id as t3lib_tree_pagetree_DataProvider also uses e.g. "$node->setId('root');" The maybe wrong value is also used in TYPO3.Components.Tree.TcaCheckChangeHandler inside tree.js


Related issues

Has duplicate TYPO3 Core - Bug #26741: Error at renderMode treeRejectedSteffen Gebert2011-05-11

Actions
#1

Updated by Ernesto Baschny about 9 years ago

  • Target version changed from 4.5.8 to 4.5.12
#2

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/14285

#3

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15168

#4

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/14285

#5

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/15170

#6

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/15171

#7

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/15171

#8

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/15170

#9

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/14285

#10

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/15170

#11

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/15171

#12

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/14285

#13

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/15170

#14

Updated by Christoph Gerold over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 20 to 100
#15

Updated by Riccardo De Contardi over 3 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF