Bug #31996
closed
Workspace preview does not transfer query parameters
100%
Description
If the URL called up when previewing from the TYPO3 backend contains additional query parameters, these should be passed on to the URLs of the iframe panels of the preview view.
I have no scenario from the Core to repeat this, but I was in a situation where I manually added query parameters to the URL and was surprised to find them being ignored. This is why I'm not submitting this patch outright, but rather just uploading it here for discussion.
Incidentally this patch resolves a "todo" that was mentioned inside the PreviewController about the language parameter not always being "L". With this patch all non-workspaces related GET query parameters are retrieved, so there's no worrying about which should be the language parameter.
Files
Updated by Tolleiv Nietsch about 12 years ago
- Status changed from New to Accepted
Patch looks fine for me - would you mind sending it to Gerrit?
Updated by
Updated by Ernesto Baschny almost 12 years ago
- Target version deleted (
4.5.9)
Not really targetted to any release yet, keep up the discussion. :)
Updated by Francois Suter over 11 years ago
I'll get back to that one, I found a scenario where it happens. The target version can be reset to the next TYPO3 4.5 release, please.
Updated by Gerrit Code Review over 11 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15680
Updated by Francois Suter over 11 years ago
How to test simply:
- preview any page from a workspace
- go to your browser's address bar and add "&foo=bar" to the URL
- check the frames info: the "&foo=bar" parameter does not appear
- apply the patch and repeat the process, "&foo=bar" should be visible in both (live and workspace) frames URLs
For the record, my real-world use case is with Tesseract's displaycontroller preview function, where some parameters are passed in particular to trigger a preview of hidden elements. Since I doubt anyone has such a setup available, the above test case does fine instead.
Updated by Francois Suter over 11 years ago
I just realized that looking at the frame info is misleading. A better way to test is to really print out the GET var "foo" in the page and observe its absence/presence.
Updated by Gerrit Code Review over 11 years ago
Patch set 1 for branch workspaces_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/15704
Updated by Gerrit Code Review almost 11 years ago
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/21111
Updated by Gerrit Code Review almost 11 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21112
Updated by Gerrit Code Review over 10 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21112
Updated by Francois Suter over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset a05b4d6bfec6174036d949139439a46870ca8b55.
Updated by Michael Stucki over 10 years ago
- Project changed from 624 to TYPO3 Core
- Category changed from Workspaces to Workspaces
Updated by