Project

General

Profile

Actions

Bug #32261

closed

mkdir_deep does not set correct permissions nor create group

Added by Loek Hilgersom about 12 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
Start date:
2011-12-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

t3lib_div::mkdir_deep does not use the provided fixPermissions function and fails to set proper permissions and ownership.
Problems occur with typo3temp/Cache (see also issue 31987) and with Extension Builder (issue 29369), but possibly at other places too.

mkdir_deep uses the recursive option to create multiple, nested directories with one php mkdir command, but is based on 2 wrong assumptions:
1. if you set permissions using mkdir('path/newdir/newsubdir', 0775, TRUE); then only newsubdir gets chmodded, not newdir
2. setting permissions using mkdir is limited by the users umask (which can set to umask(0) by php but that also has drawbacks)

Additionally, mkdir_deep does not set group ownership following $TYPO3_CONF_VARS['BE']['createGroup']

The supplied patch should (IMO) make use of the already existing methods t3lib_div::mkdir and fixPermissions


Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #31987: Could not mkdir_deep with configured "folderCreateMask" depending on umaskClosed2011-11-22

Actions
Related to TYPO3 Core - Bug #26240: Use recursive option of mkdir in t3lib_div::mkdir_deepClosedChristian Kuhn2011-04-24

Actions
Actions #1

Updated by Gerrit Code Review about 12 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022

Actions #2

Updated by Gerrit Code Review about 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022

Actions #3

Updated by Gerrit Code Review about 12 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022

Actions #4

Updated by Gerrit Code Review about 12 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022

Actions #5

Updated by Gerrit Code Review about 12 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022

Actions #6

Updated by Gerrit Code Review about 12 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022

Actions #7

Updated by Gerrit Code Review about 12 years ago

Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022

Actions #8

Updated by Gerrit Code Review about 12 years ago

Patch set 8 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022

Actions #9

Updated by Gerrit Code Review about 12 years ago

Patch set 9 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022

Actions #10

Updated by Gerrit Code Review about 12 years ago

Patch set 10 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022

Actions #11

Updated by Gerrit Code Review about 12 years ago

Patch set 11 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/7022

Actions #12

Updated by Gerrit Code Review about 12 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/8637

Actions #13

Updated by Loek Hilgersom about 12 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #14

Updated by Gerrit Code Review about 12 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/9171

Actions #15

Updated by Steffen Ritter almost 12 years ago

  • Target version set to 4.7.0-beta2
Actions #16

Updated by Jigal van Hemert almost 12 years ago

Todo: abandon patch for 4.5 and mark this issue as resolved.

Actions #17

Updated by Christian Kuhn over 11 years ago

  • Status changed from Under Review to Resolved
Actions #18

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF