Bug #33165: rsaauth PHP backend calls key generation on every page request. - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #33165

closed

rsaauth PHP backend calls key generation on every page request.

Added by Alexander Opitz over 12 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Authentication

Target version:

Start date:

2012-01-13

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.6

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

the rsaauth isAvailable function was changed, that it tests also on unix systems if rsa is configured correct.

This function will be called on every page request but takes 200ms (on our Quad Core Server) ... and IMHO key generation depends on available events on a system. So slower systems have a slower key generation.

This test should go into the Service Test on installation and shouldn't be called on every page request.

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Steffen Gebert over 12 years ago

Status changed from New to Needs Feedback

Thanks for your report, Alexander.

Of course, a test key shouldn't be generated during every request.

Have you more details on this? I checked tx_saltedpasswords_autoloader::isSaltedPasswordsSupported() which I remember to have changed, but this was not called during neither Frontend nor Backend requests. Would be nice, if you could provide few more details (stack trace..)

Actions

Copy link

Updated by Alexander Opitz over 12 years ago

#0  tx_rsaauth_php_backend->isAvailable() called at [/typo3/sysext/rsaauth/sv1/backends/class.tx_rsaauth_backendfactory.php:81]
#1  tx_rsaauth_backendfactory::getBackend() called at [/typo3/sysext/rsaauth/sv1/class.tx_rsaauth_sv1.php:123]
#2  tx_rsaauth_sv1->init() called at [/t3lib/class.t3lib_div.php:5094]
#3  t3lib_div::makeInstanceService(auth, getUserFE, ,tx_aidaauth_sv_resco,tx_nrumauth_sv1) called at [/t3lib/class.t3lib_userauth.php:509]
#4  t3lib_userAuth->checkAuthentication() called at [/t3lib/class.t3lib_userauth.php:211]
#5  t3lib_userAuth->start() called at [/typo3/sysext/cms/tslib/class.tslib_feuserauth.php:155]
#6  tslib_feUserAuth->start() called at [/typo3/sysext/cms/tslib/class.tslib_fe.php:480]
#7  tslib_fe->initFEuser() called at [/typo3/sysext/cms/tslib/index_ts.php:234]
#8  require(/typo3/sysext/cms/tslib/index_ts.php) called at [/index.php:78]

Actions

Copy link

Updated by Steffen Gebert about 12 years ago

Okay.. I see two options:

revert #31188
cache the result of the key generation

Actions

Copy link

Updated by Alexander Opitz about 12 years ago

I would do following:

- remove test also for Windows
- Add a possibility to check on extension installation
- Add a possibility to check functionality in install tool (Like the ImageMagic tests)
- or add possibility to check functionality in the service tools (where it shows the extract PDF services and so on).

Actions

Copy link