Project

General

Profile

Actions

Bug #33204

closed

getFlexFormDS

Added by Felix Nagel over 12 years ago. Updated over 10 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2012-01-15
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

This is a follow-up: http://bugs.typo3.org/view.php?id=18385

Through to changes (I noticed this problem when updating to 4.6) to function getFlexFormDS (in t3lib/class.t3lib_befunc.php) TYPO3 displays PHP warnings on some installations. For example TemplaVoila uses this function and the TV Page Module will show multiple warning messages.
The problem is caused because is_file() tries to check a string which contains XML instead of a filepath. Please see above posted link for more information.

Im was asked to send a patch request to Gerrit but I dont know how. As there is no "Add new" button in the Gerrit UI I assume I will need to push my changes via Git, but to which repo address? Wiki is not helping at all (http://wiki.typo3.org/Git).
Please give me a hint so Im able to do this myself next time!

Actions #1

Updated by Julian Hofmann over 12 years ago

In this method, there are more lines (890ff., 958ff.) checking whether it is a file or a XML string:

$file = t3lib_div::getFileAbsFileName($STRING_TO_BE_CHECKED);
if ($file && @is_file($file)) {
  // It's a file
} else {
  // It's not a file
}

In my opinion this check should be done always in the same way regardless of your working patch.

Actions #3

Updated by Hendrik Reimers over 12 years ago

Also it would be nice to add an @ char to the is_file() command. Because on any other Function calls there is @is_file() to prevent the warning. After adding this small char to the specified line it works too (but not so comfortable like "strpos(..." like in the trunk.

Actions #4

Updated by Steffen Gebert over 12 years ago

  • Category set to Backend API
  • Status changed from New to Needs Feedback

Felix, what about the I want to contribute section on that wiki page?

So is there still some change required?

Actions #5

Updated by Felix Nagel over 12 years ago

Sadly, the "I want to contribute" section ends when a local repo is successfully created. A "how (and where) to push a patch & how to create gerrit ticket" guide is missing afaics.

Not if my above posted link points to a version which will be included in the next minor release. I did not test this file but it seems the posted code line should fix this issue.

Actions #6

Updated by Felix Nagel over 12 years ago

Nahhh, Im sorry. Its described in every other guide but the "Command Line on Windows" section. I missed these parts.
Perhaps the "Command Line on Windows" should be renamed as its only describes the installation process. All other guides are within the Linux/Mac section.

Actions #7

Updated by Alexander Opitz almost 11 years ago

Hi,

as this issue is very old. Does the problem still exists within newer versions of TYPO3 CMS (6.1)?

Actions #8

Updated by Alexander Opitz over 10 years ago

  • Status changed from Needs Feedback to Closed
  • Is Regression set to No

No feedback for over 90 days.

If you think, that this is the wrong decision, then please write to the mailing list typo3.teams.bugs with issue number and an explanation.

Actions

Also available in: Atom PDF