Bug #33866
closed
show uid of reference in show_item.php
Added by Joh. Feustel about 12 years ago. Updated over 11 years ago.
100%
Description
In #29774 the "References to this item" table was changed to show the actual title of the referenced record. Now the uid is not shown anymore and if there are more items with same title there is no easy way to identify the record in the backend.
Solution is to just add the uid and pid in the title attribute of the record title.
Files
| 33866.diff (1.34 KB) 33866.diff | Joh. Feustel, 2012-02-12 14:15 |
Updated by Joh. Feustel about 12 years ago
- File 33866.diff 33866.diff added
Just wrapped in a span tag and added uid and pid as title attribute. This is applied also for the table title since if the record title is long getRecordTitle() crops it and returns the full title also in a span with title attribute. Therefore the browser would show this title and not the uid in the tooltip.
Updated by Gerrit Code Review about 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8992
Updated by Gerrit Code Review about 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8992
Updated by Thorsten Kahler about 12 years ago
- Status changed from Under Review to Accepted
Adding the same information twice is not a valid solution. And hiding the information in title attribute either.
Updated by Joh. Feustel about 12 years ago
Having the id in the tooltip looks like a common solution for me in the backend. Its there in the pagetree and in the list module.
The idea of addig it to the table title also was to have it available if records title has its own tooltip. While it looks important to still have it on the record title for default case.
Would you reintroduce the uid column instead?
I think this should happen in #33808 later.
Updated by Markus Klein about 12 years ago
Thorsten, can you please leave this on "Under Review" and post your comments in gerrit!
Updated by Thorsten Kahler about 12 years ago
Markus Klein wrote:
Thorsten, can you please leave this on "Under Review" and post your comments in gerrit!
IMHO this is the place to discuss the bug and the (approach to the) solution. If I have to say something about the code you'll find it in Gerrit for sure.
Updated by Thorsten Kahler about 12 years ago
- Category set to Backend User Interface
Joh. Feustel wrote:
Having the id in the tooltip looks like a common solution for me in the backend. Its there in the pagetree and in the list module.
Yes, and in both cases there are ways to show the uid directly (TSconfig in pagetree and column selection in list module).
The idea of adding it to the table title also was to have it available if records title has its own tooltip. While it looks important to still have it on the record title for default case.
The reasons you gave in comment 1 were already clear enough :) But doing things twice is a well-known anti-pattern.
Would you reintroduce the uid column instead?
I think this should happen in #33808 later.
I think the uid column should be reintroduced, yes. And in #33808 I could imagine to add a linked info icon, which opens yet another instance of the "View Item" popup. But that decision is up to the UX/UI team and I fear we won't get that in before feature freeze today (there already are outstanding feature requests).
I'd drop the "sorting" column in favour of uid, because that don't add any useful information here (at least, that's what occurs to me).
Updated by Gerrit Code Review about 12 years ago
- Status changed from Accepted to Under Review
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8992
Updated by Gerrit Code Review about 12 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8992
Updated by Markus Klein about 12 years ago
Thorsten Kahler wrote:
Markus Klein wrote:
Thorsten, can you please leave this on "Under Review" and post your comments in gerrit!
IMHO this is the place to discuss the bug and the (approach to the) solution. If I have to say something about the code you'll find it in Gerrit for sure.
I agree, but still I feel it's not right to set a ticket back to "Accepted" when a patch is filed to gerrit.
Nevertheless, I'll review your patch now.
Updated by Gerrit Code Review about 12 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8992
Updated by Gerrit Code Review about 12 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8992
Updated by Gerrit Code Review about 12 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8992
Updated by Gerrit Code Review about 12 years ago
Patch set 8 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/8992
Updated by Gerrit Code Review about 12 years ago
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9005
Updated by Gerrit Code Review about 12 years ago
Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9005
Updated by Joh. Feustel about 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 29f59041e3eb26cdef0be4964348aa15181eaa74.
Updated by Gerrit Code Review about 12 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/9358
Updated by Wouter Wolters over 11 years ago
This ticket can be closed, all affected branches are up to date. Except 4.5 which this patch does not apply. See http://www.typo3-anbieter.de/typo3-merges/core.html and look for 33866
Updated by Stefan Galinski over 11 years ago
- Status changed from Under Review to Closed