Bug #34308

With "virtual page-root" review-grid needs restriction to mountpoints

Added by Stefan Neufeind over 7 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Category:
Workspaces
Target version:
Start date:
2012-02-26
Due date:
% Done:

100%

TYPO3 Version:
4.7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

With the addition of the "virtual page-root"-feature (#33852) a person which is not admin now has a root-node to click on to get a full view of changes across all mountpoints (requested in #30630).
But the griddata-functions need to restrict data shown to the mountpoints visible to that person. Check if pid=0 (the real "page-root") is in the list of mountpoints, and if not fetch changes from below all mountpoints visible.


Related issues

Related to TYPO3 Core - Feature #30630: Could not get a full list of changes in workspace module Closed 2011-10-07

Associated revisions

Revision 1a644c8c (diff)
Added by Stefan Neufeind over 7 years ago

[BUGFIX] With "virtual page-root" review-grid needs restriction
to mountpoints visible

With the "virtual page-root"-feature (#33852) a person which is
not admin now has a root-node to click on to get a full view of
changes across all mountpoints (requested in #30630).

If person may not see the "real" page-root (pid=0) the selection
needs to be limited to changes from all visible mountpoints.

Change-Id: I7be7191d6095005c18f05067f1350e0ccab3e67e
Fixes: #34308
Releases: 4.7
Reviewed-on: http://review.typo3.org/9248
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Philipp Gampe
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter

History

#1 Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9248

#2 Updated by Steffen Ritter over 7 years ago

  • Target version changed from 4.7.0-beta1 to 4.7.0-beta2

#3 Updated by Stefan Neufeind over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:5d304cbdc0c64457cad62cc3892e2ac43939f335.

#4 Updated by STI UdeS over 7 years ago

This patch should be applied to TYPO3 4.5 too as the same problem happens even if the virtual root is not there. Indeed, if a backend user choose "Workspace" before he chooses any page in the page tree, he will see all changes in the installation, not only those in his mountpoints. I applied the patch to 4.5.17 and it works well.

#5 Updated by Michael Stucki almost 6 years ago

  • Category set to Workspaces

#6 Updated by Michael Stucki almost 6 years ago

  • Project changed from Workspaces & Versioning to TYPO3 Core
  • Category changed from Workspaces to Workspaces

#7 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF