Bug #34686

style fix for install tool phpinfo

Added by Markus Timtner almost 9 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Backend User Interface
Target version:
-
Start date:
2012-03-09
Due date:
% Done:

100%

Estimated time:
0.10 h
TYPO3 Version:
4.6
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

The install tool stylesheet overrides some styles of phpinfo, see screenshots.

fix:

in: typo3/sysext/install/Resources/Public/Stylesheets/install.css

add
body.standalone
to line 298 and 309, so that the selector reads
body.standalone .phpinfo h1
instead of
.phpinfo h1

This style bug has been around since forever.


Files

before.png (52.3 KB) before.png before Markus Timtner, 2012-03-09 13:05
after.png (55.5 KB) after.png after Markus Timtner, 2012-03-09 13:05
install-tool-phpinfo.png (64.6 KB) install-tool-phpinfo.png Philipp Gampe, 2012-04-27 14:19
#1

Updated by Markus Timtner almost 9 years ago

screenshots got lost, here they are:

#2

Updated by Markus Timtner almost 9 years ago

due to the difference of install tool only and install tool via backend,
one needs to add

display:block;
to the mentioned selectors.

#3

Updated by Jigal van Hemert almost 9 years ago

  • Status changed from New to Accepted

Can you prepare a patch for this?

If you need information on how to contribute, you can find tutorials at:
http://wiki.typo3.org/Contribution_Walkthrough_Tutorials

#4

Updated by Jigal van Hemert almost 9 years ago

  • Category changed from Frontend to Backend User Interface
#5

Updated by Gerrit Code Review almost 9 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10793

#6

Updated by Gerrit Code Review almost 9 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10793

#7

Updated by Philipp Gampe almost 9 years ago

I looks much different for me (no purple style for me). So I can not really reproduce that.

OK, found it ... one must scroll down :)

#8

Updated by Tomita Militaru almost 9 years ago

Philipp Gampe wrote:

I looks much different for me (no purple style for me). So I can not really reproduce that.

Please scroll on that page down and you will see the purple part from that screenshot.

#9

Updated by Gerrit Code Review almost 9 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10793

#10

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10845

#11

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/10846

#12

Updated by Gerrit Code Review almost 9 years ago

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at http://review.typo3.org/10847

#13

Updated by Tomita Militaru over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#14

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13118

#15

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13240

#16

Updated by Wouter Wolters over 8 years ago

Please close this issue. All affected branches are up to date.

#17

Updated by Stefan Galinski over 8 years ago

  • Status changed from Under Review to Closed

Also available in: Atom PDF