Bug #34860: Fix for Bug #30352 introduced in 4.5.12 breaks live search results - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #34860

closed

Fix for Bug #30352 introduced in 4.5.12 breaks live search results

Added by Jo Hasenau over 12 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Stefan Galinski

Category:

Pagetree

Target version:

4.5.14

Start date:

2012-03-14

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.5

PHP Version:

5.3

Tags:

Complexity:

easy

Is Regression:

Sprint Focus:

Description

While investigating performance problems with live search, we noticed that the results won't show up as expected anymore.

You get a list of results in the live search box.
When you click on it, the result will be opened in the page module frayme below, but immediately after that the page tree is reloaded and replaces the result with the original page module view.

Since this has been a working feature in 4.5.x already we tried to track it down and found out, that the bug can be found in the file

Ext.ux.state.TreePanel.js

which has been changed in 4.5.12 to fix bug #30352.

Despite some other known problems, the 4.5.11 version works as expected.

Related issues 3 (0 open — 3 closed)

Actions

Copy link

Updated by Jo Hasenau over 12 years ago

Assignee set to Stefan Galinski

Actions

Copy link

Updated by Helmut Hummel over 12 years ago

Status changed from New to Accepted
Assignee deleted (~~Stefan Galinski~~)

OK, can reproduce it.

It works btw. if the pagetree is in "filter mode"

Actions

Copy link

Updated by Felix Kopp over 12 years ago

Can reproduce this. Also I can reproduce that opening results works fine when the pagetree is in filtered mode.
4.6, 4.7

4.5 still works

When this line is removed:
this.commandProvider.singleClick(node, this);

(Line 121 in Ext.ux.TreePanel.js)

I see no need for the singleClick:
without the line Bookmarking works, opening Bookmarks works, opening Search results works, page tree works, filtering page tree works.
Also opening recent documents work.

This works on a pageId within right frame and also without id set.

I do not know what the click is for.

The commandProvider is set to (commandProvider: TYPO3.Components.PageTree.Actions).

Can anyone tell me what the singleClick is for?

Actions

Copy link

Updated by Gerrit Code Review over 12 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9860

Actions

Copy link

Updated by Gerrit Code Review over 12 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/9860

Actions

Copy link

Updated by Stefan Galinski over 12 years ago

Assignee set to Stefan Galinski

Hi,

I think I found a proper solution that doesn't breaks anything, but fixes all(?) open issues with unloadable content due instant pagetree refreshes. Please review this single-liner carefully!

BTW: Sorry, that I didn't saw this issue in the bookmarks patch, but as I didn't knew the proper behaviour of the search, I didn't really expected that this was broken. ;-)

Actions

Copy link