Bug #35070

[Install tool] Image processing doesn't run script of file exists

Added by Soren Malling over 7 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2012-03-21
Due date:
% Done:

100%

TYPO3 Version:
4.6
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Try this:

Make sure that you have been through the Image processing module once, so the test images have been created.

Enter a wrong path in im_path (or imagine that you move a installation, and the path to IM changes) and go to image processing again.

Install tool will report that everything went perfectly and you will see the create test images.

https://skitch.com/sorenmalling/8m7e8/new-typo3-site-typo3-4.7-dev

The case is, that no new images are trying to be created (with the wrong im_path!) and you will just see the images from typo3temp

Try and find the image in the typo3temp folder, delete it and rerun the Image Processing, you will now get a error beacause the typo3temp doesn't exists and Image processing will try and create it, with a wrong im_path

Associated revisions

Revision dc047c7f (diff)
Added by Wouter Wolters about 6 years ago

[BUGFIX] Install tool sanitizes image generation output

If execute path to ImageMagick or GraphicsMagick is not configured
correctly, the "Test setup" image tests in the install tool may show
false positives and do not render an error message that the image
generation faild.
The patch adds checks and displays an error message if for example
['GFX']['im_path'] is set to an invalid path.
There are other issues in this area, for example existing test
image files may be re-used with a broken configuration. These
are also fixed with this patch.

Change-Id: Id3cf116b80371379eae9c9dc348d9daee9d5b074
Resolves: #35070
Releases: 6.2
Reviewed-on: https://review.typo3.org/23797
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring

History

#1 Updated by Jigal van Hemert over 7 years ago

  • Status changed from New to Accepted

#2 Updated by Steffen Ritter over 7 years ago

  • Target version deleted (4.7.0)

#3 Updated by Gerrit Code Review about 6 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23797

#4 Updated by Gerrit Code Review about 6 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23797

#5 Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23797

#6 Updated by Gerrit Code Review about 6 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23797

#7 Updated by Gerrit Code Review about 6 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23797

#8 Updated by Gerrit Code Review about 6 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/23797

#9 Updated by Wouter Wolters about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF