Bug #36296

New task button missing after deleting task

Added by Alexander Jahn over 10 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Should have
Category:
scheduler
Target version:
Start date:
2012-04-18
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If a task is deleted the following window does not show the button to add a new task.

This is caused by function getDocHeaderButtons() in tx_scheduler_Module line 1568:

if (empty($this->CMD) || $this->CMD == 'list') {

Headerbuttons are only rendered if no command was issued or if the command is 'list'.

I suggest adding command 'delete' to the list so the buttons shows up again after deleting a task.

I found this in both TYPO3 4.6.8 and TYPO3 4.7.0rc2


Files

missing_button.JPG (32.6 KB) missing_button.JPG Missing "Add Task" button after deleting task Alexander Jahn, 2012-04-18 14:59
class.tx_scheduler_module.php_4-6-8.patch (634 Bytes) class.tx_scheduler_module.php_4-6-8.patch Patch for scheduler in TYPO3 4.6.8 Alexander Jahn, 2012-04-18 14:59
class.tx_scheduler_module.php_4-7-0.patch (634 Bytes) class.tx_scheduler_module.php_4-7-0.patch Patch for scheduler in TYPO3 4.7.0 Alexander Jahn, 2012-04-18 14:59

Related issues

Related to TYPO3 Core - Bug #36923: After deleting task, "New Task" button disappearsClosed2012-05-07

Actions
#1

Updated by Felix Kopp over 10 years ago

I can reproduce this.
Thank you very much for the patch - would you like to push the patchset to gerrit (the review server)?

Here you can find the Walkthrough that explains how to get your patchset into the core:
http://wiki.typo3.org/Contribution_Walkthrough

#2

Updated by Francois Suter over 10 years ago

  • Target version deleted (4.7.0)
#3

Updated by Alexander Jahn over 10 years ago

I'd really like to push my patch to gerrit but port 29418 is blocked in my company's firewall. This won't change.

Could you do that for me, please?

#4

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10700

#5

Updated by Julian Hofmann over 10 years ago

I can reproduce this in LTS version (4.5), too.

#6

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10851

#7

Updated by Gerrit Code Review over 10 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/10852

#8

Updated by Alexander Jahn over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#9

Updated by Francois Suter about 10 years ago

  • Assignee set to Christian Kuhn
  • Target version set to 6.0.0
#10

Updated by Gerrit Code Review about 10 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13122

#11

Updated by Gerrit Code Review about 10 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13244

#12

Updated by Christian Kuhn almost 10 years ago

  • Status changed from Under Review to Resolved

Merged in all relevant versions.

#13

Updated by Michael Stucki over 8 years ago

  • Category set to scheduler
#14

Updated by Michael Stucki over 8 years ago

  • Project changed from 739 to TYPO3 Core
  • Category changed from scheduler to scheduler
#15

Updated by Riccardo De Contardi almost 5 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF