Bug #36296: New task button missing after deleting task - TYPO3 Core - TYPO3 Forge

Actions

Bug #36296

closed

New task button missing after deleting task

Added by Alexander Jahn over 12 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

scheduler

Target version:

Start date:

2012-04-18

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

If a task is deleted the following window does not show the button to add a new task.

This is caused by function getDocHeaderButtons() in tx_scheduler_Module line 1568:

if (empty($this->CMD) || $this->CMD == 'list') {

Headerbuttons are only rendered if no command was issued or if the command is 'list'.

I suggest adding command 'delete' to the list so the buttons shows up again after deleting a task.

I found this in both TYPO3 4.6.8 and TYPO3 4.7.0rc2

Files

Download all files

missing_button.JPG (32.6 KB) missing_button.JPG	Missing "Add Task" button after deleting task	Alexander Jahn, 2012-04-18 14:59
class.tx_scheduler_module.php_4-6-8.patch (634 Bytes) class.tx_scheduler_module.php_4-6-8.patch	Patch for scheduler in TYPO3 4.6.8	Alexander Jahn, 2012-04-18 14:59
class.tx_scheduler_module.php_4-7-0.patch (634 Bytes) class.tx_scheduler_module.php_4-7-0.patch	Patch for scheduler in TYPO3 4.7.0	Alexander Jahn, 2012-04-18 14:59

Related issues 1 (0 open — 1 closed)

Actions

#1

Updated by Felix Kopp over 12 years ago

I can reproduce this.
Thank you very much for the patch - would you like to push the patchset to gerrit (the review server)?

Here you can find the Walkthrough that explains how to get your patchset into the core:
http://wiki.typo3.org/Contribution_Walkthrough

Actions

#2

Updated by Francois Suter over 12 years ago

Target version deleted (~~4.7.0~~)

Actions

#3

Updated by Alexander Jahn over 12 years ago

I'd really like to push my patch to gerrit but port 29418 is blocked in my company's firewall. This won't change.

Could you do that for me, please?

Actions

#4

Updated by Gerrit Code Review over 12 years ago

Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/10700

Actions

#5

Updated by Julian Hofmann over 12 years ago

I can reproduce this in LTS version (4.5), too.

Actions

#6

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/10851

Actions

#7

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/10852

Actions

#8

Updated by Alexander Jahn over 12 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 1db371c44ab6642420b01ea96bfbb603ace93531.

Actions

#9

Updated by Francois Suter over 12 years ago

Assignee set to Christian Kuhn
Target version set to 6.0.0

Actions

#10

Updated by Gerrit Code Review over 12 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at http://review.typo3.org/13122

Actions

#11

Updated by Gerrit Code Review over 12 years ago

Patch set 1 for branch TYPO3_4-6 has been pushed to the review server.
It is available at http://review.typo3.org/13244

Actions

#12

Updated by Christian Kuhn about 12 years ago

Status changed from Under Review to Resolved

Merged in all relevant versions.

Actions

#13

Updated by Michael Stucki almost 11 years ago

Category set to scheduler

Actions

#14

Updated by Michael Stucki almost 11 years ago

Project changed from 739 to TYPO3 Core
Category changed from scheduler to scheduler

Actions

#15

Updated by Riccardo De Contardi about 7 years ago

Status changed from Resolved to Closed

Actions

Also available in: Atom PDF