Project

General

Profile

Actions

Feature #37180

closed

Extjs shall not overwrite $GLOBALS['error']

Added by Franz Holzinger over 12 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Could have
Assignee:
-
Category:
-
Target version:
-
Start date:
2012-05-15
Due date:
% Done:

100%

Estimated time:
PHP Version:
5.3
Tags:
Complexity:
Sprint Focus:

Description

The file 't3lib/extjs/class.t3lib_extjs_extdirectrouter.php' overwrites the global error variable.

public function route($ajaxParams, TYPO3AJAX $ajaxObj) {
$GLOBALS['error'] = t3lib_div::makeInstance('t3lib_extjs_ExtDirectDebug');

This leads to a collision with other debug extensions which use the $GLOBALS['error']. It should better check if this variable has already been set by another extension and not overwrite it.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Epic #68075: Remove ExtJS from backendClosed2014-11-04

Actions
Actions #1

Updated by Franz Holzinger over 12 years ago

Another solution would be to change the variable $GLOBALS['error'] into an array of objects. Then all the debug functions of all those objects should be called in config_default.php.

Actions #2

Updated by Philipp Gampe over 12 years ago

But changing it into an array would break existing extensions, wouldn't it?

Actions #3

Updated by Franz Holzinger over 12 years ago

Yes, a change into an error would break current extensions. However there are only very few debug extension which use the global ERROR object. So this won't hurt. The extension which use debugging just have lines containing 'debug' and nothing else.
I think that currently there are only 3 debug extensions. Their code can be adapted for a newer version of TYPO3.

Actions #4

Updated by Mathias Schreiber almost 10 years ago

  • Target version set to 7.1 (Cleanup)

should be namespaced to TYPO3.ERROR or something alike.

Actions #5

Updated by Benni Mack over 9 years ago

  • Target version changed from 7.1 (Cleanup) to 7.4 (Backend)
Actions #6

Updated by Susanne Moog over 9 years ago

  • Target version changed from 7.4 (Backend) to 7.5
Actions #7

Updated by Benni Mack about 9 years ago

  • Target version deleted (7.5)
Actions #8

Updated by Georg Ringer over 7 years ago

  • Related to Epic #68075: Remove ExtJS from backend added
Actions #9

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53817

Actions #10

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53817

Actions #11

Updated by Gerrit Code Review about 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53817

Actions #12

Updated by Benni Mack about 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF