Feature #37180
closed
Extjs shall not overwrite $GLOBALS['error']
100%
Description
The file 't3lib/extjs/class.t3lib_extjs_extdirectrouter.php' overwrites the global error variable.
public function route($ajaxParams, TYPO3AJAX $ajaxObj) {
$GLOBALS['error'] = t3lib_div::makeInstance('t3lib_extjs_ExtDirectDebug');
This leads to a collision with other debug extensions which use the $GLOBALS['error']. It should better check if this variable has already been set by another extension and not overwrite it.
Updated by Franz Holzinger over 12 years ago
Another solution would be to change the variable $GLOBALS['error'] into an array of objects. Then all the debug functions of all those objects should be called in config_default.php.
Updated by Philipp Gampe over 12 years ago
But changing it into an array would break existing extensions, wouldn't it?
Updated by Franz Holzinger over 12 years ago
Yes, a change into an error would break current extensions. However there are only very few debug extension which use the global ERROR object. So this won't hurt. The extension which use debugging just have lines containing 'debug' and nothing else.
I think that currently there are only 3 debug extensions. Their code can be adapted for a newer version of TYPO3.
Updated by Mathias Schreiber almost 10 years ago
- Target version set to 7.1 (Cleanup)
should be namespaced to TYPO3.ERROR or something alike.
Updated by Benni Mack over 9 years ago
- Target version changed from 7.1 (Cleanup) to 7.4 (Backend)
Updated by Susanne Moog over 9 years ago
- Target version changed from 7.4 (Backend) to 7.5
Updated by Georg Ringer about 7 years ago
- Related to Epic #68075: Remove ExtJS from backend added
Updated by Gerrit Code Review about 7 years ago
- Status changed from New to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53817
Updated by Gerrit Code Review about 7 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53817
Updated by Gerrit Code Review about 7 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53817
Updated by Benni Mack about 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 0b52db2e4adf9ec7d8467834cc721f7f9245d3d0.