Bug #38024
closedIllegal string offsets in t3lib_stdgraphic
100%
Description
PHP Warning: Illegal string offset 'maxW' in t3lib/class.t3lib_stdgraphic.php line 2414 PHP Warning: Illegal string offset 'maxH' in t3lib/class.t3lib_stdgraphic.php line 2430 PHP Warning: Illegal string offset 'minW' in t3lib/class.t3lib_stdgraphic.php line 2493 PHP Warning: Illegal string offset 'minH' in t3lib/class.t3lib_stdgraphic.php line 2499 PHP Warning: Illegal string offset 'noScale' in t3lib/class.t3lib_stdgraphic.php line 2215
Happens with current master, e.g. when calling the news plugin in the frontend.
Files
Updated by Thomas Deinhamer over 12 years ago
- File 38024.patch 38024.patch added
Attached a patch, but probably
you need to modify it, cause at
least the filepath is wrong.
Would anyone be so kind to
adapt and commit this to gerrit?
The patch matches against
the current master.
Thanks a lot!
Updated by Wouter Wolters over 12 years ago
Thanks for the patch, will create one on current master and push it to Gerrit.
Updated by Gerrit Code Review over 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12543
Updated by Gerrit Code Review about 12 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12543
Updated by Gerrit Code Review about 12 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12543
Updated by Gerrit Code Review about 12 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12543
Updated by Gerrit Code Review about 12 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12543
Updated by Gerrit Code Review about 12 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/12543
Updated by Wouter Wolters about 12 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 13fe75df88c11ee6e694d450dae63e66eea92eb5.
Updated by Stefan Maischner over 10 years ago
Error still exists in TYPO3 6.1.8..
Updated by Stefan Neufeind over 10 years ago
- Is Regression set to No
I guess it refers to typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php then? What lines do you see in the error-messages?
Maybe please file another issue for 6.1+ then. I guess if there is still a problem it might affect 6.2.x as well.
Updated by Robert Steindl over 10 years ago
Error still there in 6.1.9, indeed in GraphicalFunctions.php in line 2285
Updated by Jonathan Heilmann over 10 years ago
The error is still there in 6.2.4 and refers to typo3/sysext/core/Classes/Imaging/GraphicalFunctions.php line 2216.
But it also depends on the PHP version.
I've called the imageMagickConvert function by this line:
TYPO3\CMS\Core\Imaging\GraphicalFunctions::imageMagickConvert("fileadmin/introduction/downloads/TYPO3_Logo_Guide_v3.pdf", "jpg", "1", "1", "", 0, "", 1)
PHP 5.3.26: no error
PHP 5.4.16: error
PHP 5.5.14: error
If I use the following line, no error occurs:
TYPO3\CMS\Core\Imaging\GraphicalFunctions::imageMagickConvert("fileadmin/introduction/downloads/TYPO3_Logo_Guide_v3.pdf", "jpg", "1", "1", "", 0, array(), 1)
The only difference is the next to last parameter, not "" but array().
Maybe this helps to find a solution for core, or is a hint for extension-developers running into this error.
Updated by Stefan Neufeind over 10 years ago
API says that the parameter needs to be an array. And core seems to have correct usage of the API in all places. So it would be up to extension-developers to please adjust their API-calls if they call it with a string instead. (We could add checked for is_array() in the function - but imho we can't check for correct API-usage in each and every place ...).
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed