Project

General

Profile

Actions

Bug #39859

closed

No thumbnail if removing file extension from title

Added by Tanel Põld almost 12 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2012-08-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Thumbnails are not shown if file extension is removed from Title field.
Affected: page module and element browser. Screenshots added...


Files

Picture_10.png (85.3 KB) Picture_10.png Changing original title and removing file extension Tanel Põld, 2012-08-16 14:01
Picture_9.png (33.8 KB) Picture_9.png No thumbnail in Element Browser Tanel Põld, 2012-08-16 14:01
Picture_5.png (7.26 KB) Picture_5.png No thumbnail in page module (first three in the list) Tanel Põld, 2012-08-16 14:01

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #39884: Cannot reference to a file after changing it's titleClosed2012-08-17

Actions
Related to TYPO3 Core - Bug #36795: Changing the "title" of a file breaks some functionalityClosed2012-05-03

Actions
Actions #1

Updated by Alexander Opitz over 11 years ago

I can confirm this problem.

Actions #2

Updated by Alexander Opitz over 11 years ago

I traced this problem down to an API problem inside the API.

TYPO3\CMS\Core\Resource\AbstractFile->name: Name of this file.
TYPO3\CMS\Core\Resource\File->__construct($fileData) $fileData: Array of the sys_file DB entry.
$fileData['name']: Value of the table field "name" in "sys_file" table.

But this field is the title field.

TYPO3\CMS\Core\Resource\AbstractFile->getExtension() does a pathinfo to the property "name" to get the extension, which already lies in the property "properties" of AbstractFile. And why lowercase it?

TYPO3\CMS\Core\Resource\Driver\LocalDriver->extractFileInformation() This function again uses the fileName of the file for the "name" property of the AbstractFile and not the one from the Storage. TYPO3\CMS\Core\Resource\Filter\FileExtensionFilter->filterFileList() asks the Driver and not the Storage?

I didn't read any FAL design, as there is nothing in the wiki, but this looks a bit like a problem inside the API.

Actions #3

Updated by Andreas Wolf over 11 years ago

  • Project changed from 1401 to TYPO3 Core
Actions #4

Updated by Andreas Wolf over 11 years ago

  • Category set to File Abstraction Layer (FAL)
  • TYPO3 Version set to 6.0
Actions #5

Updated by Andreas Wolf over 11 years ago

  • Status changed from New to Accepted
Actions #6

Updated by Andreas Wolf over 11 years ago

This should be fixed with the patch for #39884 and #36795.

Actions #7

Updated by Andreas Wolf over 11 years ago

  • Status changed from Accepted to Under Review
Actions #8

Updated by Gerrit Code Review over 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14260

Actions #9

Updated by Gerrit Code Review over 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/14260

Actions #10

Updated by Anonymous over 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF