Task #39928
closedCentral function to correctly (locale-aware) escape filenames and shell-args
100%
Description
The functionality below appears in 3 places in core currently (and one more currently under review).
We should add a central function for that (t3lib_div? hmm ...)
Appears in:
t3lib/class.t3lib_stdgraphic.php
t3lib/thumbs.php
t3lib/file/Service/FileProcessingService.php
And patch for review at: https://review.typo3.org/9177 (feature for 6.0 possibly, feature #34227)
Taken from: t3lib/class.t3lib_stdgraphic.php
protected function wrapFileName($inputName) {
if ($GLOBALS['TYPO3_CONF_VARS']['SYS']['UTF8filesystem']) {
$currentLocale = setlocale(LC_CTYPE, 0);
setlocale(LC_CTYPE, $GLOBALS['TYPO3_CONF_VARS']['SYS']['systemLocale']);
}
$escapedInputName = escapeshellarg($inputName);
if ($GLOBALS['TYPO3_CONF_VARS']['SYS']['UTF8filesystem']) {
setlocale(LC_CTYPE, $currentLocale);
}
return $escapedInputName;
}
Updated by Michael Stucki almost 12 years ago
- Status changed from New to Accepted
- Complexity set to easy
Updated by Mathias Schreiber over 9 years ago
- Target version set to 7.1 (Cleanup)
Updated by Gerrit Code Review over 9 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35959
Updated by Gerrit Code Review over 9 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35959
Updated by Gerrit Code Review over 9 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35959
Updated by Gerrit Code Review over 9 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35959
Updated by Gerrit Code Review over 9 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/35959
Updated by Stefan Neufeind over 9 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 8f7e48a98f2227f877cd7a96508add8bf290c47c.
Updated by Riccardo De Contardi almost 7 years ago
- Status changed from Resolved to Closed