Feature #40729

Unify modes for "Display constants" in TS object browser

Added by Philipp Kitzberger almost 7 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Could have
Assignee:
-
Category:
Backend User Interface
Target version:
Start date:
2012-09-07
Due date:
% Done:

100%

PHP Version:
Tags:
Complexity:
hard
Sprint Focus:

Description

The different modes for displaying constants in the backend modul "Template / Object browser" could be unified by displaying the "substituted constants in green" and having the "unsubstituted constants" as a title attribute. then one wouldnt have to change between those two modes anymore and since "Plain substitution" is redundant anyway, we could get rid of the entire feature of having different modes at all ;-)

Associated revisions

Revision 332ed405 (diff)
Added by Philipp Kitzberger over 1 year ago

[FEATURE] Display (un)substituted TS constant

Display value of TS constants on "UN-substituted constants in green"
mode and constant name when on "Substituted constant in green" mode.

Before this patch toggling between both modes was necessary to simply
get an idea of what the value/variable name was while being on the
'other' mode.

As a side effect this patch improves the search feature of the object
browser when searching for a constant value or name, i.e. 'maxWInText'
while being on "Substituted" mode.

Resolves: #40729
Releases: master
Change-Id: Ic8c3f1b96b3b440a3ed4d098604e29d018129451
Reviewed-on: https://review.typo3.org/50190
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

History

#1 Updated by Jigal van Hemert almost 7 years ago

  • Category set to Backend User Interface
  • Priority changed from Should have to Could have
  • Target version set to 6.1.0

It's a change in the UI so it can only go in 6.1. We probably have to find a better way than the title to display the unsubstituted constants.

#2 Updated by Mathias Schreiber over 4 years ago

  • Target version changed from 6.1.0 to 7.4 (Backend)
  • Complexity set to hard

#3 Updated by Philipp Kitzberger over 4 years ago

What about clicking on the green substituted string to find out about the unsubstituted variable name? Toggle in an overlay? Along with a link to the ts-browser in constant mode?

Or a global toggle mechanism between those two modes that changes between green substituted string and green unsubstituted variable with javascript only on the client?

Is anyone going to rewrite the whole ts object browser?

#4 Updated by Susanne Moog almost 4 years ago

  • Target version changed from 7.4 (Backend) to 7.5

#5 Updated by Benni Mack almost 4 years ago

  • Target version changed from 7.5 to 8 LTS

#6 Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50190

#7 Updated by Philipp Kitzberger almost 3 years ago

After 4 years of waiting and being annoyed that I still have to toggle between "UN-substituted constants in green" and "Substituted constants in green" whenever I was working with the TS object browser, I today dug out this ancient issue and wrote a tiny patch to tackle this once and for all.

Please be merciful with your review and include this patch to the core ;-)

#8 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50190

#9 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50190

#10 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50190

#11 Updated by Riccardo De Contardi over 2 years ago

  • Target version changed from 8 LTS to 9.0

#12 Updated by Philipp Kitzberger over 2 years ago

You're seriously postponing this again? Just merge it already ;-) Sometimes it's really anything but satisfying wanting to contribute to this project!

#13 Updated by Gerrit Code Review over 1 year ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50190

#14 Updated by Gerrit Code Review over 1 year ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50190

#15 Updated by Gerrit Code Review over 1 year ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50190

#16 Updated by Philipp Kitzberger over 1 year ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#17 Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF