Bug #41052
closed
Make Core\Configuration\ConfigurationManager non static
100%
Description
- It seems to be much more clever if this class is non static, so it can be mocked in tests without problems.
- The class might implement Singleton, but this can be left out, too
Updated by Christian Kuhn over 11 years ago
probably needs patches in core, dbal, intro and gov. package then.
Updated by Gerrit Code Review over 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15267
Updated by Gerrit Code Review over 11 years ago
Patch set 1 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15268
Updated by Gerrit Code Review over 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15267
Updated by Gerrit Code Review over 11 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15267
Updated by Gerrit Code Review over 11 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15267
Updated by Gerrit Code Review over 11 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15267
Updated by Gerrit Code Review over 11 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at http://review.typo3.org/15267
Updated by Helmut Hummel over 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b53b9f1edfff709305135a4965cf44df61d974c7.
Updated by Riccardo De Contardi over 6 years ago
- Status changed from Resolved to Closed