Bug #42271: Update LocalConfiguration fails (Install Tool: Upgrade Wizard) - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #42271

closed

Update LocalConfiguration fails (Install Tool: Upgrade Wizard)

Added by Jana Golinowski almost 12 years ago. Updated almost 7 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

Target version:

6.0.0-RC1

Start date:

2012-10-22

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.0

PHP Version:

5.3

Tags:

Complexity:

medium

Is Regression:

Sprint Focus:

Description

Due to recent changes in typo3/sysext/core/Classes/Configuration/ConfigurationManager.php the Upgrade Wizard always fails when trying to migrate localconf.php to LocalConfiguration.php.

In typo3/sysext/install/Classes/CoreUpdates/LocalConfigurationUpdate.php (line 112) the new configuration shall be written like this:

\TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Core\\Configuration\\ConfigurationManager')->writeLocalConfiguration($TYPO3_CONF_VARS);

But the ConfigurationManager never creates the configuration file. In typo3/sysext/core/Classes/Configuration/ConfigurationManager.php the method writeLocalConfiguration() checks if the that file exists and if it's writable:

if (!@is_file($localConfigurationFile) || !@is_writable($localConfigurationFile)) {
    throw new \RuntimeException($localConfigurationFile . ' does not exist or is not writable.', 1346323822);
}

When I try to perform an upgrade from 4.7 to 6.0 this new LocalConfiguration.php cannot exist. Without that file check the upgrade is fine.

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Felix Oertel almost 12 years ago

Was broken, while making it non-static (http://review.typo3.org/15267). Also no error message is displayed, just "Update FAILED!".

Actions

Copy link

Updated by Benni Mack almost 12 years ago

Status changed from New to Accepted

Actions

Copy link

Updated by Benni Mack almost 12 years ago

Complexity set to medium

Actions

Copy link

Updated by Christian Kuhn almost 12 years ago

The update wizards converts localconf.php to LocalConfiguration.php

Within this process, LocalConfiguration.php should be freshly created:

typo3/sysext/install/Classes/CoreUpdates/LocalConfigurationUpdate.php:
// Write out new LocalConfiguration file
\TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Core\\Configuration\\ConfigurationManager')->writeLocalConfiguration($TYPO3_CONF_VARS);

writeLocalConfiguration() checks if the file exists with @is_file() and throws an exception if not ... so at this point, the ugrade wizard always throws exception #1346323822

One solution is to think about the file existance check in writeLocalConfiguration(), another one is to 'touch' an empty LocalConfiguration file in the wizard first. Furthermore the should show a better meaningful message if it fails (eg. the exceptions getMessage).

Actions

Copy link