Bug #42849
closed
Could not get the extensionlist in RC1
Added by Stephan Herold over 11 years ago.
Updated over 9 years ago.
Category:
Extension Manager
Description
When I open the "Get Extensions"-Tab at a fresh installation, the called UpdateFromTerController.php produced a fatal at line 107, cause the $repository->getLastUpdate()
is null.
107: if ($repository->getLastUpdate()->getTimestamp() < $GLOBALS['EXEC_TIME'] - 24 * 60 * 60 || $forceUpdateCheck)
Respond from UpdateFromTerController.php
Fatal error: Call to a member function getTimestamp() on a non-object in /var/www/virtual/multi.heroldhansen.de/htdocs/typo3/sysext/extensionmanager/Classes/Controller/UpdateFromTerController.php on line 107
- Target version set to 2222
- Project changed from 2269 to TYPO3 Core
- Category set to Extension Manager
- Target version deleted (
2222)
- Status changed from New to Rejected
- Status changed from Rejected to Under Review
Steps to reproduce:
- truncate table
tx_extensionmanager_domain_model_extension
- go to the extension manager
- update extension list
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
- Status changed from Resolved to New
This patch had to be reverted with https://review.typo3.org/#/c/19651/ and https://review.typo3.org/#/c/19654/
It triggered quite some side effects (especially in tests) that need to be resolved, before it could be merged again. After 2 hours of fixin, it still was not possible to get running tests on travis (which are not always reproducible in own environments, probably because of different error handling settings):
- The em utility classes should not implement SingletonIntefaces
- There are not mocked dependencies in some tests
- Some em classes are instantiated with makeInstance() instead of the objectManager, thus those classes can not get things injected and do things in __construct() instead. This is an issue especially with the singleton thing. This can not be solved easily, as parts of install tool and packages (gov, intro) rely on using makeInstance at some places
- Utilities need to be discoupled better (do not call repositories for example) and must be more stupid.
- Maybe some parts of the uitilities should be services instead that are better encapsulated?
Quite some refactorings need to be done here.
- Status changed from New to Closed
- Is Regression set to No
Also available in: Atom
PDF