Bug #43447

admPanel.override.edit.editNoPopup = 1 doesn't work

Added by Frank Frewer over 6 years ago. Updated 10 months ago.

Status:
New
Priority:
Should have
Assignee:
-
Category:
AdminPanel
Start date:
2012-11-29
Due date:
% Done:

0%

TYPO3 Version:
4.5
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The User TSconfig 'admPanel.module.edit.forceNoPopup' is deprecated, but 'admPanel.override.edit.editNoPopup = 1' doesn't work.

typo3/sysext/feedit/view/class.tx_feedit_editpanel.php / function 'editPanelLinkWrap_doWrap':

        if ($GLOBALS['BE_USER']->uc['TSFE_adminConfig']['edit_editNoPopup'] || $GLOBALS['BE_USER']->extAdminConfig['module.']['edit.']['forceNoPopup']) {
...

$GLOBALS['BE_USER']->uc['TSFE_adminConfig']['edit_editNoPopup'] is not true although 'admPanel.override.edit.editNoPopup = 1' is set in user TSconfig.

In typo3/sysext/cms/tslib/class.tslib_adminpanel.php / function 'initialize' $GLOBALS['BE_USER']->uc['TSFE_adminConfig']['edit_editNoPopup'] is set only under this condition:

        if (t3lib_div::_GP('ADMCMD_editIcons')) {
            $GLOBALS['TSFE']->displayFieldEditIcons=1;
            $GLOBALS['BE_USER']->uc['TSFE_adminConfig']['edit_editNoPopup'] = 1;
        }

Should be expanded:
        if ($this->extGetFeAdminValue('edit', 'editNoPopup')) {
            $GLOBALS['BE_USER']->uc['TSFE_adminConfig']['edit_editNoPopup'] = 1;
        }
        if (t3lib_div::_GP('ADMCMD_editIcons')) {
            $GLOBALS['TSFE']->displayFieldEditIcons=1;
            $GLOBALS['BE_USER']->uc['TSFE_adminConfig']['edit_editNoPopup'] = 1;
        }


Related issues

Related to TYPO3 Core - Feature #61095: feedit - Bring back editNoPopup? Closed 2014-08-20
Related to TYPO3 Core - Epic #84044: Admin Panel Rework Closed 2010-08-11

Associated revisions

Revision 9c39b035 (diff)
Added by Paul Golmann over 4 years ago

[TASK] feedit: Bring back editNoPopup

  • Restore edit_editNoPopup/forceNoPopup TSConfig options removed in #49640
  • Initialize frontend editing when displayFieldEditIcons is set

Releases: master, 6.2
Resolves: #61095
Related: #43447
Related: #49640
Change-Id: I900a62b447a1a67265ce22cd73e150646344e090
Reviewed-on: http://review.typo3.org/32279
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision 31222b51 (diff)
Added by Paul Golmann over 4 years ago

[TASK] feedit: Bring back editNoPopup

  • Restore edit_editNoPopup/forceNoPopup TSConfig options removed in #49640
  • Initialize frontend editing when displayFieldEditIcons is set

Releases: master, 6.2
Resolves: #61095
Related: #43447
Related: #49640
Change-Id: I900a62b447a1a67265ce22cd73e150646344e090
Reviewed-on: http://review.typo3.org/35142
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Mathias Schreiber over 4 years ago

  • Target version set to 7.2 (Frontend)
  • Is Regression set to No

#2 Updated by Benni Mack about 4 years ago

  • Target version changed from 7.2 (Frontend) to 7.4 (Backend)

#3 Updated by Susanne Moog almost 4 years ago

  • Target version changed from 7.4 (Backend) to 7.5

#4 Updated by Benni Mack almost 4 years ago

  • Target version changed from 7.5 to 7 LTS

#5 Updated by Mathias Schreiber over 3 years ago

  • Target version deleted (7 LTS)

#6 Updated by Riccardo De Contardi over 1 year ago

#7 Updated by Susanne Moog 11 months ago

  • Category set to AdminPanel

#8 Updated by Susanne Moog 11 months ago

  • Target version set to 9 LTS

#9 Updated by Susanne Moog 10 months ago

  • Target version changed from 9 LTS to Candidate for patchlevel

Also available in: Atom PDF