Feature #45498
closedFind best-matching local storage instead of default-storage
Added by Stefan Neufeind almost 12 years ago. Updated about 6 years ago.
100%
Description
If a "legacy" file/folder is to be accessed (no storage-uid given) usually the default-storage will be used. But for example the Filelist-module will default to using the auto-created fileadmin-storage (Local-driver). All files added/changed will be indexed in sys_file for that respective storage and not the default-storage (ID 0). So we save us a lot of trouble to also try to use a best-matching storage (fileadmin or maybe also for other paths) instead of using the default-storage (legacy-storage).
Updated by Gerrit Code Review almost 12 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18290
Updated by Gerrit Code Review over 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18290
Updated by Gerrit Code Review over 11 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18290
Updated by Gerrit Code Review over 11 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18290
Updated by Gerrit Code Review over 11 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18290
Updated by Gerrit Code Review over 11 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18290
Updated by Gerrit Code Review over 11 years ago
Patch set 7 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18290
Updated by Gerrit Code Review over 11 years ago
Patch set 8 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18290
Updated by Gerrit Code Review over 11 years ago
Patch set 9 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18290
Updated by Stefan Neufeind over 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset c111ddecca0f903a98a57b3d3bd1bbca2c999826.
Updated by Gerrit Code Review over 11 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23291
Updated by Gerrit Code Review over 11 years ago
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/23292
Updated by Gerrit Code Review about 11 years ago
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/23557
Updated by Gerrit Code Review about 11 years ago
Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23560
Updated by Gerrit Code Review about 11 years ago
Patch set 2 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/23557
Updated by Gerrit Code Review about 11 years ago
Patch set 2 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23560
Updated by Gerrit Code Review about 11 years ago
Patch set 3 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/23560
Updated by Gerrit Code Review about 11 years ago
Patch set 3 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/23557
Updated by Stefan Neufeind about 11 years ago
- Status changed from Under Review to Resolved
Applied in changeset 046967d98785ce5a363158661f061b9ae505d248.
Updated by aimcom no-lastname-given about 11 years ago
In one of my TYPO3 projects, I ran into a major issue which is related to this new method findBestMatchingStorageByLocalPath(&$localPath)
. The image rendering doesn't work any more if an image is not located in one of the configured file storages.
Example
I have configured two different file storages: fileadmin/user_upload/
and uploads/
. After that, I created an empty page with a TypoScript template which contains:
page.10 = IMAGE page.10.file = fileadmin/images/dummy.png
In TYPO3 6.1.4, the method getFileObjectFromCombinedIdentifier($identifier)
returned the correct file object, but in TYPO3 6.1.5, this doesn't work any more because the method findBestMatchingStorageByLocalPath(&$localPath)
returns the file storage for fileadmin/user_upload/
, but the image is located in fileadmin/images/
.
Question / Conclusion
What I don't know now is if this is a bug or not. Is it true that you can only use files with the cObject IMAGE if they are located in a local storage since TYPO3 6.1.5 or is there something wrong with the functionality of findBestMatchingStorageByLocalPath(&$localPath)
? I think that the call of PathUtility::getCommonPrefix(array($basePath, $localPath));
in findBestMatchingStorageByLocalPath(&$localPath)
might be the source of my problem.
Any help is appreciated, thank you.
Updated by Markus Klein about 11 years ago
The findBestMatchingStorageByLocalPath() method simply does not check whether the file requested actually exists in the selected storage!
Updated by Markus Klein about 11 years ago
Moved to a separate issue: http://forge.typo3.org/issues/52173