Bug #45550: Having colPos 0 and columns not assigned multiplies elements in page module view - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #45550

closed

Having colPos 0 and columns not assigned multiplies elements in page module view

Added by Jo Hasenau about 11 years ago. Updated over 6 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Jo Hasenau

Category:

Backend User Interface

Target version:

4.5.24

Start date:

2013-02-17

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

4.5

PHP Version:

5.3

Tags:

Complexity:

no-brainer

Is Regression:

Sprint Focus:

Description

When using a backend layout with columns that should not be used at all, you can just leave the colPos value blank having the page module show some placeholder with the label not assigned.

Despite the fact that there actually should be a label for this column available (see #25157), the problem is, that any of the "not assigned" columns will show the content of the column with colPos 0. The cause is a missing check for colPos being no empty string. This leads to multiplied content elements in the page module view of these layouts, since the elements are visible in any column having !colPos (which is true for colPos 0 as well).

Files

Fix_for__45550.diff (2.29 KB) Fix_for__45550.diff

Jo Hasenau, 2013-02-17 17:20

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Jo Hasenau about 11 years ago

File Fix_for__45550.diff Fix_for__45550.diff added

Attached patch should solve the problem.

Actions

Copy link

Updated by Georg Ringer about 11 years ago

do you wanna push that go gerrit?

Actions

Copy link

Updated by Gerrit Code Review about 11 years ago

Status changed from New to Under Review

Patch set 1 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/18347

Actions

Copy link

Updated by Gerrit Code Review about 11 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18349

Actions

Copy link

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18349

Actions

Copy link

Updated by Alexander Opitz about 11 years ago

Hi, maybe you can change the lines in your patch to

                            if (isset($columnConfig['colPos']) && $columnConfig['colPos'] !== '' && $head[$columnKey]) {
                                $grid .= $head[$columnKey] . $content[$columnKey];
                            } elseif ($columnConfig['colPos'] !== '') {
                                $grid .= $this->tt_content_drawColHeader($GLOBALS['LANG']->getLL('noAccess'), '', '');
                            } elseif ($columnConfig['name'] !== '') {
                                $grid .= $this->tt_content_drawColHeader($columnConfig['name'], '', '');
                            } else {
                                $grid .= $this->tt_content_drawColHeader($GLOBALS['LANG']->getLL('notAssigned'), '', '');
                            }

then you also got the name as label on such columns as you want in #25157

Actions

Copy link