Bug #45575

Epic #65814: Make Indexed search extbase plugin shine

indexed_search_mysql ignores "sections" settings

Added by Quoc-Viet Phan over 6 years ago. Updated 12 months ago.

Status:
Closed
Priority:
Should have
Category:
Indexed Search
Target version:
-
Start date:
2013-02-18
Due date:
% Done:

100%

Estimated time:
0.00 h
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

If you use the extension indexed_search_mysql with V 6.0.x and want to use "sections" you will find that this will not work.
The reason is simple: the method (sectionTableWhere) in parent class is not use in the hook

Solution:
Change in typo3/sysext/indexed_search/MysqlFulltextIndexHook.php

in Function execFinalQuery_fulltext() :


$resource = $GLOBALS['TYPO3_DB']->exec_SELECTquery(
'index_fulltext.*, ISEC.*, IP.*',
'index_fulltext, index_section ISEC, index_phash IP' . $pageJoin,
'MATCH (' . $searchData['fulltextIndex'] . ') AGAINST (' . $GLOBALS['TYPO3_DB']->fullQuoteStr($searchData['searchString'], 'index_fulltext') . $searchBoolean . ') ' .
$this->pObj->mediaTypeWhere() . ' ' .
$this->pObj->languageWhere() .
$freeIndexUidClause . '
AND index_fulltext.phash = IP.phash
AND ISEC.phash = IP.phash
AND ' . $pageWhere,
'IP.phash,ISEC.phash,ISEC.phash_t3,ISEC.rl0,ISEC.rl1,ISEC.rl2,ISEC.page_id,ISEC.uniqid,IP.phash_grouping,IP.data_filename ,IP.data_page_id ,IP.data_page_reg1,IP.data_page_type,IP.data_page_mp,IP.gr_list,IP.item_type,IP.item_title,IP.item_description,IP.item_mtime,IP.tstamp,IP.item_size,IP.contentHash,IP.crdate,IP.parsetime,IP.sys_language_uid,IP.item_crdate,IP.cHashParams,IP.externalUrl,IP.recordUid,IP.freeIndexUid,IP.freeIndexSetId'
);

to


$resource = $GLOBALS['TYPO3_DB']->exec_SELECTquery(
'index_fulltext.*, ISEC.*, IP.*',
'index_fulltext, index_section ISEC, index_phash IP' . $pageJoin,
'MATCH (' . $searchData['fulltextIndex'] . ') AGAINST (' . $GLOBALS['TYPO3_DB']->fullQuoteStr($searchData['searchString'], 'index_fulltext') . $searchBoolean . ') ' .
$this->pObj->mediaTypeWhere() . ' ' .
$this->pObj->languageWhere() .
$freeIndexUidClause . '
AND index_fulltext.phash = IP.phash
AND ISEC.phash = IP.phash
AND ' . $pageWhere . $this->pObj->sectionTableWhere(),
'IP.phash,ISEC.phash,ISEC.phash_t3,ISEC.rl0,ISEC.rl1,ISEC.rl2,ISEC.page_id,ISEC.uniqid,IP.phash_grouping,IP.data_filename ,IP.data_page_id ,IP.data_page_reg1,IP.data_page_type,IP.data_page_mp,IP.gr_list,IP.item_type,IP.item_title,IP.item_description,IP.item_mtime,IP.tstamp,IP.item_size,IP.contentHash,IP.crdate,IP.parsetime,IP.sys_language_uid,IP.item_crdate,IP.cHashParams,IP.externalUrl,IP.recordUid,IP.freeIndexUid,IP.freeIndexSetId'
);

MysqlFulltextIndexHook.php View (8.19 KB) Quoc-Viet Phan, 2013-02-18 14:54

Associated revisions

Revision 97d1ce3d (diff)
Added by Tymoteusz Motylewski over 3 years ago

[BUGFIX] Indexed Search mysql takes section settings into account

Add section where clause to Indexed Search MySQL hook.
Before this patch, when using MySQL fulltext search, Indexed Search
returned results from all pages.
Now they are filtered taking correct section into account.

Releases: 7.6, master
Resolves: #45575
Change-Id: Ia5c2d2cbb2e866a4c4d56cc05ac97a85f491e6eb
Reviewed-on: https://review.typo3.org/45976
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Frank Nägler <>
Tested-by: Frank Nägler <>

Revision ddaa9adf (diff)
Added by Tymoteusz Motylewski over 3 years ago

[BUGFIX] Indexed Search mysql takes section settings into account

Add section where clause to Indexed Search MySQL hook.
Before this patch, when using MySQL fulltext search, Indexed Search
returned results from all pages.
Now they are filtered taking correct section into account.

Releases: 7.6, master
Resolves: #45575
Change-Id: Ia5c2d2cbb2e866a4c4d56cc05ac97a85f491e6eb
Reviewed-on: https://review.typo3.org/46042
Reviewed-by: Frank Nägler <>
Tested-by: Frank Nägler <>

History

#1 Updated by Quoc-Viet Phan over 6 years ago

  • Assignee set to Michael Stucki

#2 Updated by Steffen Gebert over 6 years ago

  • Project changed from forge.typo3.org to TYPO3 Core
  • Assignee deleted (Michael Stucki)
  • Target version deleted (0.3)

Dear Quic-Viet,

I've moved this issue to the correct project. Thanks for reporting!

#3 Updated by Quoc-Viet Phan over 6 years ago

Hi Steffen,

Thank you for moving the ticket in the right place.
Do you know what the process is for the ticket moves into the next release?
And how long will it take?

Sincerely,
Quoc-Viet.

#4 Updated by Quoc-Viet Phan over 6 years ago

The file is : typo3/sysext/indexed_search/Classes/Hook/MysqlFulltextIndexHook.php

Not : typo3/sysext/indexed_search/MysqlFulltextIndexHook.php

#5 Updated by Alexander Opitz over 5 years ago

  • Category set to Indexed Search
  • TYPO3 Version set to 6.0
  • Is Regression set to No

#6 Updated by Lorenz Ulrich almost 5 years ago

I can confirm that this issue is still present in TYPO3 6.2

#7 Updated by Tymoteusz Motylewski over 4 years ago

  • Assignee set to Tymoteusz Motylewski
  • Parent task set to #65814

#8 Updated by Tymoteusz Motylewski over 4 years ago

  • Complexity set to easy

#9 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/45976

#10 Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/46042

#11 Updated by Tymoteusz Motylewski over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#12 Updated by Benni Mack 12 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF