Project

General

Profile

Actions

Bug #45833

closed

BE List Module - issues with call to itemsProcFunc and non-selected fields

Added by RVVN no-lastname-given about 11 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Start date:
2013-02-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
4.6
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

TYPO3 4.6.16 apparently added a completely new fragment of code to "Have labels respect possible itemsProcFunc results" in BE List module, using t3lib_TCEForms->procItems.

file:
typo3_src/typo3/class.db_list_extra.inc

function:
renderListRow()

line:
634

The 'row' Array from the data object passed to itemsProcFunc only contains selected fields.
Problem is, if a itemsProcFunc needs the value of a non-selected field, an exception is raised because the 'row' Array doesn't contain this field.

In my personal case, I use an extension (Realty Manager - realty) with an itemsProcFunc for the "district" field that needs the value of the "city" field in order to retrieve districts for this city.
It's OK if I select "city" field, but crashes if not.

I'm not sure that's a core related ('row' Array may now contain all fields ?) or if that itemsProcFunc needs to be re-designed (maybe using pure TCA configuration with 'foreign_table'…).


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #25113: itemsProcFunc is not taken into account while generating labels for select items in the list moduleClosed2011-02-20

Actions
Actions #1

Updated by Michael Stucki about 11 years ago

  • Status changed from New to Under Review

I sent a mail to the author of the change that caused this problem, asking him to take a look at your bug.

Actions #2

Updated by Christian Kuhn about 11 years ago

How to reproduce realty isuse, verified in core version 4.6:

  • install ext:realty and dependencies (eg. in 4.6)
  • Add some sysfolder to page
  • Go to list module, create a record 'Realty object', safe + close -> db error in list module.

The patch that introduced the issue has multiple other flaws and is reverted in all versions for now.

Actions #3

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18941

Actions #4

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/18942

Actions #5

Updated by Gerrit Code Review about 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18941

Actions #6

Updated by Gerrit Code Review about 11 years ago

Patch set 3 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/18942

Actions #7

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/18944

Actions #8

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch TYPO3_4-6 has been pushed to the review server.
It is available at https://review.typo3.org/18945

Actions #9

Updated by Gerrit Code Review about 11 years ago

Patch set 2 for branch TYPO3_4-5 has been pushed to the review server.
It is available at https://review.typo3.org/18943

Actions #10

Updated by Christian Kuhn about 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF