Project

General

Profile

Actions
Copy link

Bug #46000

closed

Wrong usage of array_unique() in RootlineUtility.php

Added by Andreas Lingott over 11 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Performance
Target version:
-
Start date:
2013-03-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.0
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The array_unique() function has no effect because the returned array is NOT used and were not assigned to the static variable self::$rootlineFields

Impact:
We will get a very huge SQL statement after some loops (up to 2 MB SQL), see attached file "t3.sample.sql".
Database gets very busy and load time of page increases.

Original file: RootlineUtility.php
File fixed: RootlineUtility.new.php
Diff file is attached: RootlineUtility.php.diff

From package: introductionpackage-6.0.2

Files

Download all files
t3.sample.sql (1.48 MB) t3.sample.sql Andreas Lingott, 2013-03-04 09:16
RootlineUtility.new.php (13.4 KB) RootlineUtility.new.php Andreas Lingott, 2013-03-04 09:16
RootlineUtility.php (13.3 KB) RootlineUtility.php Andreas Lingott, 2013-03-04 09:16
RootlineUtility.php.diff (573 Bytes) RootlineUtility.php.diff Andreas Lingott, 2013-03-04 09:16

Related issues 1 (0 open — 1 closed)

Related to TYPO3 Core - Task #39352: Refactor t3lib_pageSelect::getRootlineClosedSteffen Ritter2012-07-28

Actions
Actions
Copy link

Also available in: Atom PDF