Bug #46261
closedIndexing files does not store the language
100%
Description
By default, the files that get indexed are bound to a specific page ID, but the file in the index is not bound to a specific language. This results in showing / not showing the files in the wrong situations.
Setup:¶
- Given a site with DE (L=0) as default and FR (L=1) as additional language
- There is a page that links to files:
- The German Page links to a file "DE.pdf" that contains the word "Deutsch"
- The French Page links to a file "FR.pdf" that contains the word "français"
- The page is being indexed via FE-Indexing, in both languages
Expected:¶
- Searching for "Deutsch" should
- find the "DE.pdf" file while searchin in the DE-Frontend
- NOT find the "DE.pdf" file when searching in the FR-Frontend (as it's not linked to the FR-Page!)
- Searching for "français" (with or without the special character, searching for "francais" results in the same behavior) should
- find the "FR.pdf" file while searching in the FR-Frontend
- NOT find the "FR.pdf" file when searching in the DE-Fronten (as it's not linked on the DE-page!)
Current Behavior:¶
All indexed files are only ever shown when searching in the default language - and of course only when they match the search term.
In the FR-page, no single file is being shown as search result - because the file is indexed/stored with "sys_language_uid == 0" in the database.
Proposed Change:¶
I'll add a patch soonish that just adds the sys_language_uid when storing an indexed file to the current sys_language_uid that is being used by TSFE. This works fine for us and solves the above mentioned issue and did not show any negative side-effects in several customer projects.
Updated by Georg Ringer over 11 years ago
IMO sys_language_content should be used, not the uid itself to be able to care about fallbacks ?!
Updated by Gerrit Code Review over 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18899
Updated by Oliver Hader over 11 years ago
- Project changed from 1382 to TYPO3 Core
Updated by Gerrit Code Review over 11 years ago
- Status changed from New to Under Review
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/18899
Updated by Anonymous over 11 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 85ea7bf9cc00e4b77da4399aa9118fed4c8f8743.
Updated by Gerrit Code Review over 11 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/22333
Updated by Gerrit Code Review over 11 years ago
Patch set 1 for branch TYPO3_6-0 has been pushed to the review server.
It is available at https://review.typo3.org/22334
Updated by Anonymous over 11 years ago
- Status changed from Under Review to Resolved
Applied in changeset d88c564db8564aa83de817f33a7964af0b1afc03.
Updated by Gerrit Code Review over 11 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_4-7 has been pushed to the review server.
It is available at https://review.typo3.org/22347
Updated by Mario Rimann about 11 years ago
We need a Release-Manager decision here, as only certain changes can go into 4.7.x - and that's the only thing that's still pending -> it's merged in master (6.2), 6.1 and 6.0 branches already.
Updated by Frans Saris about 10 years ago
- Status changed from Under Review to Resolved
- TYPO3 Version set to 6.2
- Is Regression set to No