Project

General

Profile

Actions

Bug #48474

closed

Suggest Wizard doesn't work properly when inside Flexform repeating elements

Added by Gabe Blair almost 11 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend User Interface
Target version:
Start date:
2013-05-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
5.4
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

The "suggest" wizard does not work properly when it is added to a field on a repeating flexform element. Screenshot attached.

I'll attache a patch, which breaks out a small component of TYPO3\CMS\Backend\Form\Element\SuggestElement::processAjaxRequest() into a recursive function to handle the determination of conf for a particular DS field.


Files

Screen_Shot_2013-05-22_at_4.12.02_PM.png (37 KB) Screen_Shot_2013-05-22_at_4.12.02_PM.png Can't search for pages using the suggest wizard Gabe Blair, 2013-05-23 01:27
48474_suggest_wizard_flexform.patch (1.75 KB) 48474_suggest_wizard_flexform.patch Gabe Blair, 2013-05-23 01:30
example48474_0.0.0.zip (2.53 KB) example48474_0.0.0.zip Gabe Blair, 2013-07-17 02:57
example48474.tar.gz (2.27 KB) example48474.tar.gz Gabe Blair, 2013-07-17 02:57

Related issues 2 (0 open2 closed)

Related to TYPO3 Core - Bug #55835: Suggest wizard does not work correctly in flexformsClosed2014-02-10

Actions
Related to TYPO3 Core - Bug #75494: Suggest wizard not working in flexform array element when not the last fieldClosed2016-04-11

Actions
Actions #1

Updated by Gabe Blair almost 11 years ago

Patch attached. Should I try to submit this to code review, or...?

Actions #2

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20990

Actions #3

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20990

Actions #4

Updated by Gerrit Code Review almost 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20990

Actions #5

Updated by Gerrit Code Review almost 11 years ago

Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20990

Updated by Gabe Blair over 10 years ago

Attached is a sample extension to use for testing this (to go along with the latest patch set). Hopefully that will be enough to get this patch rolled into the next release. To use the test extension:

  • Install it from either the .t3x or .tar.gz attached
  • Add a content element of type "Example for Bug #48474" to a page
  • Try out the suggest wizard on the "Repeating Element" tab - should be broken
  • Cherry pick the patch from Gerritt
  • Try out the suggest wizard again - should work

I included non-repeating element with a suggest wizard on another flexform tab, so you can verify that continues to work before and after the patch

Thanks and regards,

Gabe

Actions #7

Updated by Alexander Opitz over 10 years ago

  • Target version changed from 6.1.1 to next-patchlevel

Hi Gabe,

thanks for your help. Please, can you rebase your patch to latest master? As it can't be merged anymore.

Actions #8

Updated by Gerrit Code Review over 10 years ago

Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20990

Actions #9

Updated by Gerrit Code Review over 10 years ago

Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20990

Actions #10

Updated by Gabe Blair over 10 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF