Bug #48474
closed
Suggest Wizard doesn't work properly when inside Flexform repeating elements
100%
Description
The "suggest" wizard does not work properly when it is added to a field on a repeating flexform element. Screenshot attached.
I'll attache a patch, which breaks out a small component of TYPO3\CMS\Backend\Form\Element\SuggestElement::processAjaxRequest() into a recursive function to handle the determination of conf for a particular DS field.
Files
Updated by Gabe Blair almost 11 years ago
Patch attached. Should I try to submit this to code review, or...?
Updated by Gerrit Code Review almost 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20990
Updated by Gerrit Code Review almost 11 years ago
Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20990
Updated by Gerrit Code Review almost 11 years ago
Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20990
Updated by Gerrit Code Review almost 11 years ago
Patch set 4 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20990
Updated by Gabe Blair almost 11 years ago
- File example48474_0.0.0.zip example48474_0.0.0.zip added
- File example48474.tar.gz example48474.tar.gz added
Attached is a sample extension to use for testing this (to go along with the latest patch set). Hopefully that will be enough to get this patch rolled into the next release. To use the test extension:
- Install it from either the .t3x or .tar.gz attached
- Add a content element of type "Example for Bug #48474" to a page
- Try out the suggest wizard on the "Repeating Element" tab - should be broken
- Cherry pick the patch from Gerritt
- Try out the suggest wizard again - should work
I included non-repeating element with a suggest wizard on another flexform tab, so you can verify that continues to work before and after the patch
Thanks and regards,
Gabe
Updated by Alexander Opitz almost 11 years ago
- Target version changed from 6.1.1 to next-patchlevel
Hi Gabe,
thanks for your help. Please, can you rebase your patch to latest master? As it can't be merged anymore.
Updated by Gerrit Code Review almost 11 years ago
Patch set 5 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20990
Updated by Gerrit Code Review almost 11 years ago
Patch set 6 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/20990
Updated by Gabe Blair over 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 0fa2da4689c0bdcb15d469590743daf41ba4fde3.
Updated by 