Bug #55835
closed
Suggest wizard does not work correctly in flexforms
100%
Description
for my plugin i use multiple suggest wizards in the flexform.
The behaviour is really weird, once i select something in wizard a everything works, when selecting something in wizard b the option i chose in wizard a is taken instead. When i add a few elements via the browser to select c and i delete one of them all will vanish...
The shown options are correct but the wrong ones are insterted plus the weird problem with the removing of records....
could be regression
48474
47413
Files
Updated by Philipp Wrann about 10 years ago
in jsfunc.tceforms_suggest.js this selector [line 101 on current master]
var suggestLabelNode = Element.select(this.escapeObjectId(item.id), '.suggest-label')[0];
allways returns the first selected item.
just a first hint... i dont have time to read further but maybe it helps.
does not explain the removing behaviour though
Updated by Markus Klein about 10 years ago
- Category changed from FormEngine aka TCEforms to Backend User Interface
- Status changed from New to Accepted
- Target version deleted (
6.2.0) - TYPO3 Version changed from 6.2 to 4.5
Can confirm that for 4.5 too
Updated by Philipp Wrann almost 10 years ago
Also 4.7, additionally in 4.7 (4.7.17) it appears also when only 1 suggest wizard is rendered.
Updated by GAYA La Nouvelle Agence almost 10 years ago
Also in 6.2.3. I join a patch of jsfunc.tceforms_suggest.js for this version. Please check it cause I'm not expert in prototype library but this works for me.
Updated by Gerrit Code Review almost 10 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30513
Updated by Gerrit Code Review almost 10 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30513
Updated by Rémy DANIEL almost 10 years ago
What is the status of this review? Why `item.id` needs to be escaped with `this.escapeObjectId()`?
Updated by Markus Klein almost 10 years ago
Hi Daniel!
Please post feedback to a patch directly in Gerrit. I just invited you there. Login with your normal TYPO3 account.
The escape is necessary due to [] characters, see https://review.typo3.org/20045
Updated by Rémy DANIEL almost 10 years ago
I fix a JS error in #59655. Maybe this is related to this particular issue, because it fixed it for me...
Updated by Gerrit Code Review almost 10 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30513
Updated by Gerrit Code Review almost 10 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30513
Updated by Gerrit Code Review almost 10 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30513
Updated by Gerrit Code Review almost 10 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/31479
Updated by Anonymous almost 10 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset a026f1873c8ae95a4feed3b7bdf0284076a65bb5.
Updated by 