TYPO3 Core

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21347

Please look at https://review.typo3.org/21346 for reviewing.

The second patch belongs to I different issue. I mixed up the numbers in the commit message :(

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/21346

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/21346

Alexander Stehlik wrote:

At the moment the RTE offers hooks to render custom tabs in the element browser (\TYPO3\CMS\Rtehtmlarear).

But even if the a hook in \*TYPO3\CMS\Recordlist\Browser\ElementBrowser::parseCurUrl()* sets a value for "act" it will be overwritten to "url" if the "data-htmlarea-external" flag is TRUE.

parseCurUrl() is NOT always able to detect that the url is considered external, in particular in multi-domain setups. Therefore the attribute data-htmlarea-external is set whenever the link is set using the "External url" tab. If such link is to be edited, the active tab must necessarily be "External url", don't you think?

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/21346

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/21346

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/21346

This issue can be closed. The problem was caused by an invalid use of the "data-htmlarea-external" attribute.

When custom links are used this attribute must not be set, otherwise the system thinks the link is external.

There are two places where you need to take care that the attribute is not set:

1. The JavaScript code that inserts the link. You can use link_spec() because it will remove the "data-htmlarea-external" attribute
2. Additionally you need to hook into the RteHtmlParser ($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_parsehtml_proc.php']['modifyParams_LinksRte_PostProc']) to make sure that the attribute is not re-inserted when the data is loaded into the RTE

For an example implementation of the hook you can have a look at https://github.com/Intera/typo3-extension-linkhandler/commit/41d29fdf30e46fa6d101af232fd1c51a9b8cda30

EDIT: You actually can use link_spec().

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27680

Finally tracked down a bug that caused the problems in the first place.

Please change the tracker to "bug".

parse_url() will return "record" as scheme for linkhandler links and RteHtmlParser::TS_links_rte() will than treat the link as external even if it is an internal link.

Please see the new changeset for a possible fix: https://review.typo3.org/27680

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27680

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27680

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/27680

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30975

Patch set 1 for branch TYPO3_6-1 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/30976