Bug #49233: FAL Migration not applied to file links in tt_content bodytext - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #49233

closed

FAL Migration not applied to file links in tt_content bodytext

Added by Nico de Haen over 11 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Francois Suter

Category:

File Abstraction Layer (FAL)

Target version:

next-patchlevel

Start date:

2013-06-19

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.1

PHP Version:

5.3

Tags:

Complexity:

medium

Is Regression:

Sprint Focus:

Description

It seems that all file links in tt_content bodytext are not migrated to point to the corresponding sys_file record. They are migrated once you open the content element in the backend but not in the Install tool update wizard which cares only for files in tt_content.image.

This means, that all file links that are not yet migrated won't reflect renaming of folders and files. If the path of a file changed the content elements are not accessible anymore due to #37409

You can easily destroy a whole site by just renaming one folder in the file list module...

To make it clear:
After running the update wizard the links still look like this (can be seen only in the database):

<link fileadmin/Downloads2/MyFile.pdf - download "Initiates file download">MyFile</link>

but should look like this:

<link file:12345 - download "Initiates file download">MyFile</link>

I'm not sure if that is a regression or if it was always like this, since I didn't find any code for that in the update wizard.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Francois Suter over 11 years ago

Status changed from New to Accepted
Assignee set to Francois Suter
Complexity set to medium

Actions

Copy link

Updated by Gerrit Code Review over 11 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22002

Actions

Copy link

Updated by Gerrit Code Review over 11 years ago

Patch set 3 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22002

Actions

Copy link

Updated by Francois Suter over 11 years ago

You don't need to have a full TYPO3 installation to upgrade to test this patch. Here are some steps for testing (after having applied the patch):

1) pick some file in your fileadmin folder (say "foo/bar.pdf").
2) edit some tt_content element directly in a database tool and insert something like:

<link fileadmin/foo/bar.pdf>Test file link</link>

in the "bodytext" field.
3) update the sys_refindex index
4) go to the upgrade wizard, the File links update wizard should tell you that there's 1 link (at least) to update
5) run the File links update wizard. It should show the update queries.
6) check the content of the tt_content element in the database. The link should have been transformed to: