Project

General

Profile

Actions
Copy link

Bug #49645

closed

Logging PHP errors to sys_log table does not work

Added by Robert Vock almost 11 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Logging
Target version:
-
Start date:
2013-07-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
5.3
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

The default error handler does not write PHP errors to the sys_log table anymore.

The bug was introduced in changeset 3e309294309458279eef2adf08af6adb8ed4a867 when the link property of the DatabaseConnection was changed from public to private.

The TYPO3\CMS\Core\Error\ErrorHandler has a check for the link property which now returns false:

171         if (is_object($GLOBALS['TYPO3_DB']) && !empty($GLOBALS['TYPO3_DB']->link)) {

The one-liner fix would be to use the new method isConnected():

171         if (is_object($GLOBALS['TYPO3_DB']) && $GLOBALS['TYPO3_DB']->isConnected()) {

Actions
Copy link
 #1

Updated by Alexander Opitz almost 11 years ago

Hi,

do you want to bring this fix to gerrit, so it can be reviewed?

Actions
Copy link
 #2

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/21970

Actions
Copy link
 #3

Updated by Robert Vock almost 11 years ago

Ok, first time I used Gerrit :)

The change is available here: https://review.typo3.org/21970

Actions
Copy link
 #4

Updated by Gerrit Code Review almost 11 years ago

Patch set 1 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22166

Actions
Copy link
 #5

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch master has been pushed to the review server.
It is available at https://review.typo3.org/22166

Actions
Copy link
 #6

Updated by Gerrit Code Review almost 11 years ago

Patch set 1 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/22171

Actions
Copy link
 #7

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/22171

Actions
Copy link
 #8

Updated by Anonymous almost 11 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #9

Updated by Gerrit Code Review almost 11 years ago

  • Status changed from Resolved to Under Review

Patch set 3 for branch TYPO3_6-1 has been pushed to the review server.
It is available at https://review.typo3.org/22171

Actions
Copy link
 #10

Updated by Anonymous almost 11 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #11

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF