Project

General

Profile

Actions

Bug #51781

closed

IMAGE content object accepts directories

Added by Alexander Stehlik over 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Content Rendering
Target version:
Start date:
2013-09-05
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
6.2
PHP Version:
Tags:
Complexity:
medium
Is Regression:
No
Sprint Focus:

Description

When the path of an image content element is the path to a dirctory and not to a real file it should not be rendered.

I think I found the problem in 6aad338a in \TYPO3\CMS\Core\TypoScript\TemplateService->getFileName().

See also:
https://git.typo3.org/Packages/TYPO3.CMS.git/blobdiff/d0c8f2903eb639bc24154cfd716ff4760cb5a9aa..6aad338a:/t3lib/class.t3lib_tstemplate.php

parse_url() accepts the path to a directory (e.g. uploads/myextension/) so it will return the path unchanged, even if the file does not exist or is a directory. In the old version of the function it only returned a value if the provided file was a real file.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #62575: Broken unit test in 6.2ClosedMarkus Klein2014-10-30

Actions
Actions #1

Updated by Gerrit Code Review over 10 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25286

Actions #2

Updated by Steffen Ritter over 10 years ago

  • Category changed from File Abstraction Layer (FAL) to Content Rendering
  • Is Regression set to No

this has nothing to do with FAL

Actions #3

Updated by Gerrit Code Review almost 10 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25286

Actions #4

Updated by Gerrit Code Review over 9 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/25286

Actions #5

Updated by Gerrit Code Review over 9 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/25286

Actions #6

Updated by Gerrit Code Review over 9 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/25286

Actions #7

Updated by Gerrit Code Review over 9 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/25286

Actions #8

Updated by Gerrit Code Review over 9 years ago

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at http://review.typo3.org/33643

Actions #9

Updated by Tomita Militaru over 9 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF