Bug #52825

\TYPO3\CMS\Extbase\Object\ObjectManagerException vs of \TYPO3\CMS\Extbase\Object\ObjectManager

Added by Oliver Hader about 6 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Extbase
Target version:
-
Start date:
2013-10-14
Due date:
% Done:

100%

TYPO3 Version:
6.0
PHP Version:
5.3
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

\TYPO3\CMS\Extbase\Object\ObjectManagerException is basically the same as the ObjectManager.
\TYPO3\CMS\Extbase\Object\ObjectManagerException has been introduced in this change:
https://git.typo3.org/TYPO3v4/CoreProjects/MVC/extbase.git/commit/569063f64331766ea780cd118f0fd6c707664c16

Update:
Link to commit that introduced this change: https://git.typo3.org/TYPO3CMS/CoreProjects/MVC/extbase.git/commit/569063f64331766ea780cd118f0fd6c707664c16


Related issues

Related to TYPO3 Core - Bug #52824: Superfluous usage of ObjectManagerException Closed 2013-10-14

Associated revisions

Revision 0e3615ba (diff)
Added by Benni Mack over 2 years ago

[BUGFIX] Extbase: Remove invalid class ObjectManagerException

There is a class called "ObjectManagerException" which was
introduced very early with Extbase and was a clone of
the (now further developed) object manager.

It was originally used in the wrong place in workspaces
and then changed in workspaces to the real object manager
but the class was kept.

This class was then wrongly renamed in TYPO3 6.0 with the
change to namespaces and called "Exception" which it is
definitively NOT and thus, plain wrong in the place as it
is.

The class (and the interface) should be removed as it
is not just plain useless and a hard mistake we carried on
for 7 years now.

Resolves: #52825
Releases: master, 8.7
Change-Id: I615caaa9d297631a338ca6488bfe8e5c29594e3b
Reviewed-on: https://review.typo3.org/53231
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

Revision 01742278 (diff)
Added by Benni Mack over 2 years ago

[BUGFIX] Extbase: Remove invalid class ObjectManagerException

There is a class called "ObjectManagerException" which was
introduced very early with Extbase and was a clone of
the (now further developed) object manager.

It was originally used in the wrong place in workspaces
and then changed in workspaces to the real object manager
but the class was kept.

This class was then wrongly renamed in TYPO3 6.0 with the
change to namespaces and called "Exception" which it is
definitively NOT and thus, plain wrong in the place as it
is.

The class (and the interface) should be removed as it
is not just plain useless and a hard mistake we carried on
for 7 years now.

Resolves: #52825
Releases: master, 8.7
Change-Id: I615caaa9d297631a338ca6488bfe8e5c29594e3b
Reviewed-on: https://review.typo3.org/53232
Tested-by: TYPO3com <>
Reviewed-by: Oliver Hader <>
Tested-by: Oliver Hader <>

History

#1 Updated by Alexander Opitz almost 6 years ago

  • Category set to Extbase
  • Status changed from Needs Feedback to New

#2 Updated by Marc Bastian Heinrichs almost 6 years ago

  • Status changed from New to Accepted
  • Target version set to 6.2.0

#3 Updated by Helmut Hummel over 5 years ago

  • Status changed from Accepted to Needs Feedback

Oliver Hader wrote:

\TYPO3\CMS\Extbase\Object\ObjectManagerException is basically the same as the ObjectManager.

What is the exact issue with this?

#4 Updated by Alexander Opitz about 5 years ago

  • Status changed from Needs Feedback to Closed
  • Target version deleted (6.2.0)

No feedback within the last 90 days => closing this issue.

If you think that this is the wrong decision or experience this issue again, then please write to the mailing list typo3.teams.bugs with issue number and an explanation or open a new ticket and add a relation to this ticket number.

#5 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Closed to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53231

#6 Updated by Oliver Hader over 2 years ago

  • Description updated (diff)

#7 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53231

#8 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53232

#9 Updated by Benni Mack over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#10 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF