Project

General

Profile

Actions

Bug #53097

closed

MEDIA / renderType / impossible to use custom renderType for video

Added by Wolfgang Klinger about 11 years ago. Updated about 9 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Target version:
-
Start date:
2013-10-24
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
6.1
PHP Version:
5.4
Tags:
Complexity:
medium
Is Regression:
Yes
Sprint Focus:

Description

hiya!
the if structure on line 178 (and following) in sysext/frontend/Classes/ContentObject/MediaContentObject.php always sets $renderType to 'swf',
so it’s impossible to use a custom renderType for video

the problem (imho) is the combination of

178         if ($renderType !== 'qt' && $renderType !== 'embed' && $conf['type'] == 'video') {

and

192             } elseif (isset($conf['file']) && !isset($conf['caption']) && !isset($conf['sources'])) {
193                 $renderType = 'swf';

as a result $renderType is always 'swf' for video
or do I miss something here (guess not)?

possibly related to http://forge.typo3.org/issues/38376


Related issues 3 (0 open3 closed)

Related to TYPO3 Core - Bug #38376: class tslib_content_media overwrites custom rendertypeClosed2012-06-25

Actions
Related to TYPO3 Core - Bug #35921: Final usability improvement for the Media ElementClosedSteffen Ritter2012-04-12

Actions
Related to TYPO3 Core - Bug #33357: Media content element doesn't work with YouTube URLsClosedSteffen Ritter2012-01-21

Actions
Actions #1

Updated by Philipp Gampe about 11 years ago

  • Status changed from New to Needs Feedback
  • Complexity set to medium
  • Is Regression changed from No to Yes

I think this is a regression introduced with #33357

To me it looks like the patch does not take custom render types into account.

You should be able to avoid this condition by setting a caption or a source.

Can you confirm that its is working then.

Actions #2

Updated by Wolfgang Klinger almost 11 years ago

Yes, setting a caption or source fixes the problem

Actions #3

Updated by Alexander Opitz almost 11 years ago

  • Status changed from Needs Feedback to New
Actions #4

Updated by Wolfgang Klinger almost 11 years ago

The problem arises again if I want to use e.g. a youtube URL as media,
because then the if condition on line 179 matches and sets the renderType to 'swf' again
(though I don’t like to have to add a caption and/or source as „solution“ for local media anyway)

Will this get fixed anytime soon? Any other workaround ideas other than hacking the core?

Actions #5

Updated by Frans Saris about 10 years ago

I'm working on a prototype to make it possible to register your own "render" helpers. Have a look at https://github.com/fsaris/fal_online_media_connector

It also makes it possible to have a text+media element instead only text+image

Actions #6

Updated by Georg Ringer about 9 years ago

  • Status changed from New to Closed

mediace has been extracted from the core and is not needed anymore using CMS7. however it can be now found at github ant the issue has been moved to https://github.com/FriendsOfTYPO3/mediace/issues/13

Actions

Also available in: Atom PDF