Bug #53556
closedEpic #55070: Workpackages
Epic #55065: WP: Overall System Performance (Backend and Frontend)
Bug #52949: Speed decrease since 4.5
classLoader->loadClass calls requireOnce twice per class
100%
Description
Inside classLoad->LoadClass each class is loaded in line 134, but again in line 156.
134:
// Loads any known class via caching framework
if ($require) {
if ($this->classesCache->requireOnce($cacheEntryIdentifier) !== FALSE) {
$cacheEntryCreated = TRUE;
}
}
156:
if ($cacheEntryCreated && $require) {
if ($this->classesCache->requireOnce($cacheEntryIdentifier) !== FALSE) {
$cacheEntryCreated = TRUE;
}
}
By looking into the logic, it seams if a require was successful in the first part, the require is repeated in the second part. You could speed it up by checking if the require was successful in the first part and avoid the second require.
Updated by Gerrit Code Review about 11 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25305
Updated by Thorsten Kahler almost 11 years ago
- Complexity set to easy
I realized that some time ago, too.
Updated by Gerrit Code Review almost 11 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25305
Updated by Wouter Wolters almost 11 years ago
- Status changed from Under Review to Closed
Not needed anymore. Closed.