Bug #53970
closed
getBaseValidatorConjunction is called for simple types
0%
Description
I could observe this issue in the TYPO3\CMS\SysNote\Controller\NoteController->listAction:
The $pids argument is of type string. Still getBaseValidatorConjunction() is called which will return nothing because it does a class_exists() check at the beginning.
Since class_exists() seems to be expensive (autoload process is triggered) it could make sense to do a check with TypeHandlingUtility::isSimpleType() before doing the class_exists() check.
Updated by Alexander Schnitzler over 10 years ago
- Status changed from New to Accepted
We are into the issues of the validation api backport and we are planning to have a codesprint in january to fix these.
Updated by Alexander Opitz over 9 years ago
- Status changed from Accepted to Needs Feedback
Hi,
was this issue fixed or does it still exists?
Updated by Alexander Stehlik over 9 years ago
The initializeControllerArgumentsBaseValidators() method in the AbstractController class is still calling getBaseValidatorConjunction() which does a class_exists() check at the beginning. The issue is still existing but since #53962 was merged is is not that big of a problem any more I think.
You could still consider adding a check for TypeHandlingUtility::isSimpleType() which might be cheaper than class_exists() but this would need some performance testing.
Updated by Alexander Opitz over 9 years ago
- Project changed from 534 to TYPO3 Core
- Category changed from Extbase: Validation to Extbase
- Status changed from Needs Feedback to New
- TYPO3 Version set to 6.2
- Is Regression set to No
Updated by