Bug #53962: Class loader does not cache non existing classes - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #53962

closed

Epic #55070: Workpackages

Epic #55065: WP: Overall System Performance (Backend and Frontend)

Bug #52949: Speed decrease since 4.5

Class loader does not cache non existing classes

Added by Alexander Stehlik almost 11 years ago. Updated about 7 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Performance

Target version:

6.2.0

Start date:

2013-11-25

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

5.4

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Just found this one while testing https://review.typo3.org/25673/:

ValidatorResolver->buildBaseValidatorConjunction()

called by

ActionController->initializeActionMethodValidators()

will always trigger the class loader because it calls:

class_exists('string')

which of course is not a class and does not exist.

Therefore it will not be stored in the cache and the whole class loader process starts all over again.

This is done by every request to the page module (by the SysNote hook).

Maybe it would make sense to store information about non existing classes in the cache?

Related issues 2 (0 open — 2 closed)

Actions

Copy link

Updated by Markus Klein almost 11 years ago

Parent task set to #52949

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25679

Actions

Copy link

Updated by Philipp Gampe almost 11 years ago

We should of course cache negative requests, but this sounds more like a bug in extbase?!?

Actions

Copy link

Updated by Alexander Stehlik almost 11 years ago

I guess you could consider this as a bug. I opened #53970 for this :)

Actions

Copy link

Updated by Thomas Maroschik almost 11 years ago

I am strongly against the caching of non existent classes. By doing so you break the class loader chain, if there are more than one class loader present.

Rather class_exists calls to simple types should be first checked via the TypeHandlingUtility.

Actions

Copy link

Updated by Alexander Stehlik almost 11 years ago

Which class loader chain do you mean?

Do you mean the native PHP chain when multiple autoloaders are registered? If so I can not see a problem because if the TYPO3 class loader fails the next one in the chain should take over, right?

Or is there a class loading chain inside the TYPO3 class loader? If so it should be possible to cache non existing classes after the chain.

I agree that the TypeHandlingUtility needs to be fixed. And I can not really think of a use case when you would run a lot of class_exist calls of non existing classes. But this does not mean it will not happen.

Do you see other problems besides the loader chain?

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25679

Actions

Copy link

Updated by Gerrit Code Review almost 11 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/25679

Actions

Copy link