Feature #54867

pagetype shortcut check for internal loop

Added by Philip Gutzeit over 5 years ago. Updated 8 months ago.

Status:
Accepted
Priority:
Should have
Assignee:
-
Category:
-
Start date:
2014-01-09
Due date:
% Done:

0%

PHP Version:
Tags:
shortcut
Complexity:
Sprint Focus:

Description

Would be nice to prevent an internal error when setting up an shortcut-page that points to itself. This might avoid some ugly error throwout and make it more obvious for normal editors. Simple solution/suggestion: make it impossible to select the page you are currently working on.


Related issues

Related to TYPO3 Core - Bug #86412: pages.shortcut suggest wizard should not suggest itself Closed 2018-09-28
Related to TYPO3 Core - Bug #86600: pages.content_from_pid should not suggest itself Closed 2018-10-09

Associated revisions

Revision ea2dfc1f (diff)
Added by Josef Glatz 9 months ago

[BUGFIX] pages.shortcut suggest wizard should not suggest itself

Make it impossible to select the page you are currently
working on within the suggest wizard result set.

Releases: master, 8.7
Resolves: #86412
Related: #54867
Change-Id: Ibeaacf86061f79cc3d75f181466e5caf96657401
Reviewed-on: https://review.typo3.org/58423
Tested-by: TYPO3com <>
Reviewed-by: Richard Haeser <>
Reviewed-by: Peter Kraume <>
Tested-by: Peter Kraume <>
Tested-by: Richard Haeser <>
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>

Revision 445afda7 (diff)
Added by Josef Glatz 9 months ago

[BUGFIX] pages.shortcut suggest wizard should not suggest itself

Make it impossible to select the page you are currently
working on within the suggest wizard result set.

Releases: master, 8.7
Resolves: #86412
Related: #54867
Change-Id: Ibeaacf86061f79cc3d75f181466e5caf96657401
Reviewed-on: https://review.typo3.org/58428
Tested-by: TYPO3com <>
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>

Revision bad2f115 (diff)
Added by Josef Glatz 8 months ago

[BUGFIX] pages.content_from_pid suggest wizard should not suggest itself

Make it impossible to select the page you are currently
working on within the suggest wizard result set.

In addition, the suggest has been improved to search also in the
following fields of page records:
  • nav_title
  • alias
  • url

Releases: master, 8.7
Resolves: #86600
Related: #54867
Change-Id: Ifce04fc5f01b5585f2320901b56be8b9970d4762
Reviewed-on: https://review.typo3.org/58597
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

Revision 58321861 (diff)
Added by Josef Glatz 8 months ago

[BUGFIX] pages.content_from_pid suggest wizard should not suggest itself

Make it impossible to select the page you are currently
working on within the suggest wizard result set.

In addition, the suggest has been improved to search also in the
following fields of page records:
  • nav_title
  • alias
  • url

Releases: master, 8.7
Resolves: #86600
Related: #54867
Change-Id: Ifce04fc5f01b5585f2320901b56be8b9970d4762
Reviewed-on: https://review.typo3.org/58613
Tested-by: TYPO3com <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>

History

#1 Updated by Benni Mack over 2 years ago

  • Project changed from v4 Usability Team to TYPO3 Core
  • Category deleted (Usability)

#2 Updated by Riccardo De Contardi about 2 years ago

  • Target version deleted (TYPO3 6.2 LTS)

#3 Updated by Josef Glatz 9 months ago

  • Related to Bug #86412: pages.shortcut suggest wizard should not suggest itself added

#4 Updated by Riccardo De Contardi 8 months ago

Partially solved with #86412 - the suggest wizard skips the page itself; but it is still possible to select the same shortcut page as shortcut and save the record without errors or warnings.

#5 Updated by Josef Glatz 8 months ago

I could imagine:

A) Show an error via MessageQueue if the actual edited page record links to it self. This informs an editor

B) what about extending the Record Browser with an additional argument where the value could be N tablename_<uid> like pages_42? Those ids are then disabled in the record browser (greyed out for example with a nice title attribute)

#6 Updated by Josef Glatz 8 months ago

  • Assignee deleted (Philip Gutzeit)
  • Target version set to Candidate for patchlevel

#7 Updated by Josef Glatz 8 months ago

  • Status changed from New to Accepted

#8 Updated by Josef Glatz 8 months ago

  • Related to Bug #86600: pages.content_from_pid should not suggest itself added

#9 Updated by Markus Klein 8 months ago

I'd go with b)

Also available in: Atom PDF